Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Migrate all existing foreign assets to XCMv4. #209

Open
acatangiu opened this issue Mar 1, 2024 · 4 comments
Open

Migrate all existing foreign assets to XCMv4. #209

acatangiu opened this issue Mar 1, 2024 · 4 comments

Comments

@acatangiu
Copy link
Contributor

We should also migrate all existing foreign assets to V4.

Originally posted by @joepetrowski in #187 (comment)
@acatangiu acatangiu mentioned this issue Mar 1, 2024
Merged
9 tasks
@franciscoaguirre
Copy link
Contributor

When updating the foreign assets from v3 to v4, I get an error in asset_test_utils::test_cases_over_bridge::receive_reserve_asset_deposited_from_different_consensus_works because it requires the runtime to have v3::Location for foreign assets in the version being used.

So in order to do it, the runtimes need to be updated to stable2409 (tested with stable2407 and it didn't cut it) because we need the parachains-runtimes-test-utils crate with version 17.0.0 and right now it's in 15.0.0.

We should move forward with #457

@acatangiu
Copy link
Contributor Author

acatangiu commented Oct 4, 2024 •
edited
Loading

I suggest skipping polkadot sdk stable2407 (#457) and going straight for polkadot sdk stable2409.

@franciscoaguirre franciscoaguirre mentioned this issue Oct 7, 2024
Merged
@franciscoaguirre
Copy link
Contributor

Ended up copying the functions from polkadot sdk and putting them here until we update to stable2409

@pandres95
Copy link
Contributor

@franciscoaguirre today I opened #490. Guess there could be a way of merging #472 over that PR, or otherwise merging it before, and then making the changes to remove the copied functions?

fellowship-merge-bot bot pushed a commit that referenced this issue Oct 24, 2024
@franciscoaguirre @bkchr
Update foreign asset ids from v3 to v4 (#472)
21f767d 
Addresses #209

Foreign assets in Asset Hub Kusama and Asset Hub Polkadot use v3
locations as ids. The newest version is v4 so this PR updates them.

No storage migration is needed since v3's and v4's encoding is the same.

Had to copy some test functions that took v3 locations into the repo
until we update it to stable2409, when they actually switch to taking v4
locations.

---------

Co-authored-by: Bastian Köcher <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@pandres95 @franciscoaguirre @acatangiu