Undecodable nomination-pool state after after upgrading to [email protected]
#188
Comments
|
This is known issue, please, check element I've prepared hotfix few days ago: paritytech/polkadot-sdk#3305 but we decided just to wait for [email protected] is enacted on Feb 19: https://polkadot.polkassembly.io/referenda/458 This is the problem with migrations, when they use actual structs from lib.rs. And the problem could happen when older migrations were not yet applied and we need to apply them all. |
|
On Monday, CI should go green, so then we can close this issue |
11 tasks
|
Confirmed this is fixed, thanks @bkontur |
bkchr
pushed a commit
that referenced
this issue
Feb 27, 2024
Based on bump to [`[email protected]`](#137). Attached result of `cargo upgrade -v --pinned --incompatible` [cargo-upgrade-version-bump.log](https://github.com/polkadot-fellows/runtimes/files/14044160/cargo-upgrade-version-bump.log) _Note: Encointer was not upgraded (because its pallet references `[email protected]` release)._ ## ~~For reviewers~~ ~~This PR is against `polkadot-fellows`'s main to bring it to the fellows repo, but if you want to see a real diff relevant to the `[email protected]` update please check: bkontur/runtimes@bko-bump-to-1.5...bkontur:runtimes:bko-bump-to-1.6.~~ ## TODO - [x] fix compilation - [x] fix integration tests - [x] fix benchmarks (also try them) - `collectives-polkadot` `payout` - [ ] ~~Does not require a CHANGELOG entry~~ - [x] `warning: use of deprecated struct `staging_xcm_builder::CurrencyAdapter`: Use `FungibleAdapter` instead` - [ ] search for `TODO:(PR#159) change to FungibleAdapter` and/or wait for paritytech/polkadot-sdk#3287 - [x] patch for `pallet-nomination-pools` migration fix paritytech/polkadot-sdk#3093 - will be fixed here #188 (comment) - [x] patch for `xcm-executor` fix (for 1.6.0) e.g. paritytech/polkadot-sdk#3174 - [x] check/fix coretime stuff for Kusama/Polkadot - search for `// TODO:(PR#159)(PR#1694)` - see [comment](#159 (comment)) - fixed by bkontur#3 - [x] check the `MaxControllersInDeprecationBatch`https://github.com/polkadot-fellows/runtimes/pull/159/files#r1492361038 - [x] check `pallet_identity::Config` for Kusama and Polkadot https://github.com/polkadot-fellows/runtimes/pull/159/files#r1492363866 --------- Signed-off-by: Adrian Catangiu <[email protected]> Co-authored-by: joe petrowski <[email protected]> Co-authored-by: Francisco Aguirre <[email protected]> Co-authored-by: Ross Bulat <[email protected]> Co-authored-by: Alain Brenzikofer <[email protected]> Co-authored-by: eskimor <[email protected]> Co-authored-by: Adrian Catangiu <[email protected]> Co-authored-by: fellowship-merge-bot[bot] <151052383+fellowship-merge-bot[bot]@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
#137 had some regression that made Polkadot nomination pool
BondedPoolstate unable to completely decode, hence we are seeing failing CI as of that merge commit (e.g. https://github.com/polkadot-fellows/runtimes/actions/runs/7911629580/job/21596088389?pr=184#step:9:1847). Thanks @joepetrowski for raising this.I'll look into it tomorrow. Probably makes sense in the future to have try-runtime CI checks be
requiredso these issues don't sneak by.The text was updated successfully, but these errors were encountered: