diff --git a/.github/review-bot.yml b/.github/review-bot.yml index 230f2d0ca5..7f81f6a3c4 100644 --- a/.github/review-bot.yml +++ b/.github/review-bot.yml @@ -9,12 +9,9 @@ rules: - name: Relay and system files condition: include: - - ^relay\/kusama\/.* - - ^relay\/polkadot\/.* + - ^relay\/.* - ^system-parachains\/.* - - ^CHANGELOG$ - exclude: - - ^relay\/.+\.adoc$ + - ^CHANGELOG.md$ type: fellows minRank: 3 minApprovals: 4 @@ -22,11 +19,10 @@ rules: condition: include: - '.*' - exclude: - - ^relay\/kusama\/.* - - ^relay\/polkadot\/.* - - ^\.github/.* + exclude: + - ^relay\/.* - ^system-parachains\/.* - - ^target\/.* + - ^\.github/.* + - ^CHANGELOG.md$ type: fellows minRank: 2 diff --git a/README.md b/README.md index d3c45fb94c..857c0a4d86 100644 --- a/README.md +++ b/README.md @@ -24,3 +24,13 @@ Do not modify the `relay/` or `system-parachains/` folder. They are currently re └── collectives └── collectives-polkadot ``` + +## Approval rights + +The approval rights are configured in [`review-bot.yml`](.github/review-bot.yml). The rights are configured as: + +- All files in `.github` require two approvals from fellow members of rank 4 or higher. +- `CHANGELOG.md`, `relay/*` or `system-parachains/*` require four approvals from fellow members of rank 3 or higher. +- All other files require the approval from one fellow member of rank 2 or higher. + +The review-bot is using the on chain identity to map from a github account to a fellowship member. This requires that each fellowship member adds its github handle to its on-chain identity. Check [here](docs/github-on-chain-identity.md) for an instruction. diff --git a/docs/github-on-chain-identity-process.jpg b/docs/github-on-chain-identity-process.jpg new file mode 100644 index 0000000000..18882e9660 Binary files /dev/null and b/docs/github-on-chain-identity-process.jpg differ diff --git a/docs/github-on-chain-identity.md b/docs/github-on-chain-identity.md new file mode 100644 index 0000000000..1aa7b32596 --- /dev/null +++ b/docs/github-on-chain-identity.md @@ -0,0 +1,7 @@ +# Adding github account to your on-chain identity + +Adding the github account to your identity requires the usage of the `additional` fields in the identity info. This is currently only supported by using the [polkadot-js bare extrinsic interface](https://polkadot.js.org/apps/?rpc=wss%3A%2F%2Frpc.polkadot.io#/extrinsics). See the following image for an example: + +![][github-on-chain-identity-process.jpg] + +You should also at least add the `display` field. If you want to add `utf8` characters, you need to hex encode them and put the hex string (`0x` prefixed) into the field. diff --git a/relay/polkadot/README.adoc b/relay/polkadot/README.adoc deleted file mode 100644 index 3337331081..0000000000 --- a/relay/polkadot/README.adoc +++ /dev/null @@ -1,5 +0,0 @@ - -= Polkadot Runtime - -placeholder -//TODO Write content :) (https://github.com/paritytech/polkadot/issues/159)