Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add reminder command #61

Open
Raia opened this issue Feb 1, 2017 · 3 comments
Open

Add reminder command #61

Raia opened this issue Feb 1, 2017 · 3 comments

Comments

@Raia
Copy link
Member

Raia commented Feb 1, 2017

Possible example:

.remindme 5 hours post the thread

Questions:

  • Should people be able to set reminders for others or just themselves?
    • Semi-related: Do we treat it like a .msg in the db and just add a delivery time field for all messages, or should reminders be their own thing? (implementation detail)
  • .remindme 5 hours post the thread or .remindme in 5 hours to post the thread?
@Kirzi
Copy link

Kirzi commented Feb 1, 2017

Should people be able to set reminders for others or just themselves?

Sure, I think that'd be good. We could have a .remind command as well for this. .remind me would do the same thing as .remindme, but only .remind would work for reminding others.

Semi-related: Do we treat it like a .msg and just add a delivery time field for all messages, or should reminders be their own thing?

Not sure what you mean? I'd just consider reminders to be separate.

.remindme 5 hours post the thread or .remindme in 5 hours to post the thread?

Why not both?

@not-an-aardvark
Copy link
Contributor

Do we treat it like a .msg and just add a delivery time field for all messages, or should reminders be their own thing?

I think it should probably be its own thing. We could store all reminders in the database, and then on startup it could fetch all the reminders and set up intervals for them.

It's probably not possible to do this with the current system of commands or tasks, so we will need a new type of thing that the bot can do.

Should people be able to set reminders for others or just themselves?

I assume the reminders get posted to the same channel that they were requested in, so they're not really tied to a specific user -- they're just channel-wide reminders that happen to have been requested by a particular person. So I think people shouldn't be able to set reminders for others (although they can ping the other person in the reminder).

.remindme 5 hours post the thread or .remindme in 5 hours to post the thread?

The first one seems easier (so that the bot doesn't have to deal with grammar such as to, etc.) but I have no strong opinion.

@not-an-aardvark
Copy link
Contributor

For future bookkeeping: The resolution here was to add a new API for tasks to be able to run at arbitrary points in time (specified by passing an event emitter to the task), rather than just at regular intervals.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants