Prefer KVO for app storage observation #3487
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
stephencelis
commented
Nov 11, 2024
| } | ||
| let willEnterForeground: (any NSObjectProtocol)? | ||
| if let willEnterForegroundNotificationName { | ||
| willEnterForeground = NotificationCenter.default.addObserver( | ||
| forName: willEnterForegroundNotificationName, | ||
| object: nil, | ||
| queue: nil | ||
| queue: .main |
There was a problem hiding this comment.
I believe this forces a thread hop, which means we should avoid the crash even on invalid KVO keys, but we could also do an explicit dispatch if we're not confident here.
stephencelis
commented
Nov 11, 2024
| @@ -60,22 +60,6 @@ extension AppStorageKeyPathKey: PersistenceKey, Hashable { | |||
| observer.invalidate() | |||
| } | |||
| } | |||
|
|
|||
| private class Observer: NSObject { | |||
There was a problem hiding this comment.
This observer wasn't used anymore.
stephencelis
commented
Nov 11, 2024
Comment on lines
+41
to
+45
| warm-simulator: | ||
| @test "$(PLATFORM_ID)" != "" \ | ||
| && xcrun simctl boot $(PLATFORM_ID) \ | ||
| && open -a Simulator --args -CurrentDeviceUDID $(PLATFORM_ID) \ | ||
| || exit 0 |
There was a problem hiding this comment.
Trying to see if we can reduce CI flakiness by warming the simulators.
mbrandonw
approved these changes
Nov 11, 2024
3 tasks
|
@stephencelis Looks like this also fixes this issue. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Observing the firehose notification from Notification Center is not only less performant, but it can cause crashes in SwiftUI if a notification is posted during a view body update, which can occur in certain situations.
Instead, we will prefer KVO unless we detect an invalid key, such as one that contains a
.or is prefixed with an@.Fixes #3311.