Add explicit @mainactor to NavigationLink initializer #3430
+37
−24
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixes the "Conformance of 'Notification' to 'Sendable' is unavailable" error
This reverts commit d8cb070.
mbrandonw
reviewed
Oct 8, 2024
Examples/CaseStudies/SwiftUICaseStudies/03-Effects-LongLiving.swift
Outdated
Show resolved
Hide resolved
mbrandonw
approved these changes
Oct 8, 2024
There was a problem hiding this comment.
Thanks for this @chrisjrex! We will get this merged and released sometime today (along with swiftui-navigation).
…swift Co-authored-by: Brandon Williams <[email protected]>
|
@chrisjrex Wanna bump the package to this version of Swift Navigation? https://github.com/pointfreeco/swift-navigation/releases/tag/2.2.2 Once you do that we can run CI and merge! |
|
@stephencelis done. 🙂 |
chrisjrex
commented
Oct 8, 2024
ComposableArchitecture.xcworkspace/xcshareddata/swiftpm/Package.resolved
Show resolved
Hide resolved
ComposableArchitecture.xcworkspace/xcshareddata/swiftpm/Package.resolved
Show resolved
Hide resolved
ComposableArchitecture.xcworkspace/xcshareddata/swiftpm/Package.resolved
Outdated
Show resolved
Hide resolved
ComposableArchitecture.xcworkspace/xcshareddata/swiftpm/Package.resolved
Show resolved
Hide resolved
ComposableArchitecture.xcworkspace/xcshareddata/swiftpm/Package.resolved
Show resolved
Hide resolved
ComposableArchitecture.xcworkspace/xcshareddata/swiftpm/Package.resolved
Show resolved
Hide resolved
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This works around regression in behavior introduced by Xcode 16 beta 3.
Following on from the fix applied to
swift-navigation.