Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

(Fix) Add checking for contract's existence to VotingToChangeProxyAddress.createBallot #184

Open
varasev opened this issue Sep 12, 2018 · 0 comments
Open

(Fix) Add checking for contract's existence to VotingToChangeProxyAddress.createBallot #184

varasev opened this issue Sep 12, 2018 · 0 comments
Assignees
@varasev

Comments

@varasev
Copy link
Contributor

varasev commented Sep 12, 2018

Problem: The VotingToChangeProxyAddress.createBallot function doesn't check proposed contract (its address) for existence:

poa-network-consensus-contracts/contracts/VotingToChangeProxyAddress.sol

Line 17 in 6c2c779

address _proposedValue

Solution: Add such checking with extcodesize opcode.
@varasev varasev self-assigned this Sep 18, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@varasev varasev

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@varasev