-
Notifications
You must be signed in to change notification settings - Fork 74
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
(Fix) add prefix to Sokol spec files #23
Comments
To avoid exceptions, I'd propose to update playbooks to add this prefix on every network, so also This would first need to be checked by updating existing nodes with old filenames on sokol. |
@phahulin is it in our pipeline? |
Yes, I guess we'll need another poa-devops playbook to update files on existing nodes |
I think this is an great idea. Even if one were to manually download the wrong bootnode.txt file (download poacore-bootnodes.txt instead of sokol-bootnodes.txt to /home/bootnode/ - no issues as it can't accidentally overwrite the 'correct' version. Another poa-devops playbook means all nodes will have current net-name-bootnode.txt files, which solves another minor issue. Good work! |
@6proof which "another minor issue" do you mean? |
By "another minor issue" I meant that not all nodes have up-to-date bootnodes.txt files. Issuing another poa-devops that pushes out changes requiring new naming convention (poacore-bootnodes.txt and sokol-bootnodes.txt for example) ensure that all nodes will have current information as of deployment of the new poa-dveops playbook. John Le Gassic and I just today were discussing ways to keep bootnodes.txt files update on all nodes, and best way to push out new info to nodes. For example, when a new Sokol Network Validator is voted in through consensus, what is the system to 1. Verify the accuracy of the new node information -2. notify the active consensus nodes of the new participant so nodes can update bootnodes.txt and reload parity and netstat services. On the same note, could use this system to temporarily sanction a non-compliant node during a Hard Fork by removing that node from consensus using same system. These are just discussions now. Perhaps this is already accounted for. Thanks for listening! |
It can cause a security issue on nodes of validators. I.e. when a c&c resource will be compromised, e.g., a GitHub account of POA Network |
I agree, Igor. Interesting discussion. |
Problem:
it's possible to make a mistake while working with two networks because similar file names
Solution:
add a prefix to
sokol-
as is:
to be:
this issue is for discussion. do you see any problems with renaming?
The text was updated successfully, but these errors were encountered: