-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Unable to use emll to get correct elasticity values on a model with ground truth values #24
Comments
@mcnaughtonadm do you have any updates? |
I do have some updates @janisshin, sorry I thought I'd have a bit more time to test a few different solutions to your problem but had an annoying paper revision that took up some extra time 🙄. So I went through and tried to run your code the way that I would go about running the Things like defining I tried to get to the step of building up the model, but ran into some problems doing it my way versus how import cloudpickle
import gzip
with gzip.open("pymc_data.pgz", "wb") as f:
cloudpickle.dump(
{
"vn": self.vn,
"en": self.en,
"xn": self.xn,
"v_inds": self.v_inds,
"ll": self.ll,
"v_star": self.v_star,
...,
},
f,
) Just include the variables you end up using to build the
|
Hi Andrew, |
checking in again to see if you've got any updates or need more things from me. |
@mcnaughtonadm, Here is the graph I'm getting I'm running the notebook again to check that the predicted flux values and predicted chi values match the groundtruth values. I hope to update the notebook with these graphs by tmrw morning. @djinnome I just wanted to give you a heads up on this discrepancy before presenting it at our Wednesday meeting. |
How are you computing the predicted elasticity values? What is returned by Bayesian MCA is a posterior distribution over each elasticity. |
I'm using
It's somewhat close. Out of the top10 ground truth FCC values, BMCA predicts about 6-7 correctly. Is this enough information or would it help if I also made a parity plot for the FCC rankings as well? I'm not sure what parameter identifiability issues are, but happy to schedule a meeting to talk about it, if necessary. |
I've made the graphs you've requested for my benchmarking project, but I had some follow up questions which will be at the bottom.
100% internal metabolite data
For elasticities,
Table columns
For the number of correctly predicted reactions in the top 10 ranked FCCs, In the cell immediately after, you'll find the ground truth rankings of the other top 10 FCC predictions that are not in the ground truth top 10 FCCs. I know you asked for the union, but I think the set difference is more useful in seeing this data.
I will aim to have this done later today. |
@djinnome , Also, I have further questions about using Originally, I chose the last option, but then I did not know how to incorporate 4aca concentration data into Can we (or @mcnaughtonadm, whoever is more appropriate) meet to discuss this? |
Hey @janisshin do you have proteomics data? If so, that is actually a better use of Eflux2 than transcriptomics data, but the normalization might need to be a bit different to account for the fact that proteomics has different distributional qualities than transcriptomics. |
I do not have proteomics data either. Should I go find some on the internet? I found this one, but I need to process the data it seems |
For the benchmark examples, I think you can just make up the proteomics data from the ground-truth model, yes? With regard to real proteomics data, it would need to come from a strain that produces your end product (4ACA in this case). You don't need to include 4ACA in the |
We don't have a Biosystems meeting tmrw, but I'm happy to meet with you tmrw at a time that is most convenient for you. Please let me know when that would be. |
I've tried using the improved emll version on a modified yeast model to try and get elasticity values and compare them to ground truth values. Here is the notebook with my work: notebook link. The ELBO convergence plot in my notebook does not seem great. Am I using
emll
correctly and is this the closest thatemll
can get to the ground truth values?Here is the model referenced in the notebook and the data.
The text was updated successfully, but these errors were encountered: