Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ability to Shrink Margin Width #358

Open
QGtKMlLz opened this issue Jun 13, 2023 · 12 comments
Open

Ability to Shrink Margin Width #358

QGtKMlLz opened this issue Jun 13, 2023 · 12 comments

Comments

@QGtKMlLz
Copy link

I Execute the command SCI_SENDMSG SCI_SETMARGINWIDTHN 1 12 in Nppexec & NppEventExec now, but after doing a compare it resets the Line Number/Bookmark width back default.

I've attach an Image comparing the widths; you'll notice how I have the bookmark icon slightly cut-off on the right side.

Even if I do it manually, I see a large margin space on each document for the ComparePlus icons. Aside from running the margin command on open, I don't know anything about nppExec, but it doesn't appear I can do anything on a Comparison event.
Bookmark Icon Width

Can we have an ability to adjust the margin?

Thank you for your work on maintaining & updating the Plugin!

@pnedev
Copy link
Owner

pnedev commented Jun 16, 2023

Hello,
I will see what I can do when I find the time.
Just a quick question: Do you suggest to implement a setting that configures the Compare diff symbols margin width or you'd like to have your margins recovered after compare as they were before it was triggered?
Thanks and regards.

@QGtKMlLz
Copy link
Author

I think 'a setting that configures the Compare diff symbols margin width' is the probably the the most beneficial option. I was thinking both?

@Yaron10
Copy link

Yaron10 commented Jun 21, 2023

@cooly0,

I Execute the command SCI_SENDMSG SCI_SETMARGINWIDTHN 1 12
...
I've attach an Image comparing the widths; you'll notice how I have the bookmark icon slightly cut-off on the right side.

"the bookmark icon slightly cut-off on the right side" has nothing to do with ComparePlus. Is that correct?
I'm trying to understand why you set the width to 12 and have the bookmark icon cut off.
Also, some of ComparePlus icons' width are 14 , and they would be cut off as well.


Hello my friend Pavel,

I hope you're doing well.

Best wishes.

@Yaron10
Copy link

Yaron10 commented Jun 21, 2023

I see a large margin space on each document for the ComparePlus icons.

It seem that space is the Changed History margin.
Could you try disabling Changed History via Preferences -> Margins?

@QGtKMlLz
Copy link
Author

QGtKMlLz commented Jun 21, 2023 via email

@Yaron10
Copy link

Yaron10 commented Jun 21, 2023

so I can get readable/type-able space.

I don't quite understand that.

Did you try to disable the Changed History margin? Or assign a different color to that margin via Style Configurator?

@QGtKMlLz
Copy link
Author

readable/type-able space : I consider notepad++ a lightweight, minimal gui editor. So I mean getting as many lines & length of line on a screen that I can that I able still able to read (use case: editing Powershell code).

I missed your comment on Changed History; thanks that did help.

@Yaron10
Copy link

Yaron10 commented Jun 21, 2023

@cooly0,

So I mean getting as many lines & length of line on a screen that I can that I able still able to read (use case: editing Powershell code).

I see.

ComparePlus margin number is 4.
You can try running SCI_SENDMSG SCI_SETMARGINWIDTHN 4 14 until @pnedev finds some time to look into it.

@pnedev
Copy link
Owner

pnedev commented Jun 22, 2023

Hello guys,

Thank you both for the discussion, suggestions and the details. I'll see what I can do.

Yaron,
Hello my friend.
Thanks for helping and best wishes.

BR

@pnedev pnedev removed the question label Jun 22, 2023
@Yaron10
Copy link

Yaron10 commented Jun 22, 2023

Hello Pavel,

Thank you for your on-going work. 👍

or you'd like to have your margins recovered after compare as they were before it was triggered?

Shouldn't this alone solve @cooly0's issue? - He would have to run SCI_SENDMSG SCI_SETMARGINWIDTHN anyway.

BR

@pnedev
Copy link
Owner

pnedev commented Jun 23, 2023

Hello Yaron,

I think you are right. Perhaps just restoring initial Npp margins as they were before comparing would be enough although Compare margin would also take space and it will be useful to be able to configure it to be narrower in such rare cases.

Thanks friend.
BR

@Yaron10
Copy link

Yaron10 commented Jun 23, 2023

Hello Pavel,

although Compare margin would also take space and it will be useful to be able to configure it to be narrower in such rare cases.

As you understand.
I just thought that @cooly0's request was extremely rare, and he's using a script anyway.

Thank you again.
Have a nice weekend.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants