Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

grid.vwXspline and friends missing argument vp = NULL ? #1

Open
bryanhanson opened this issue Aug 9, 2017 · 3 comments
Open

grid.vwXspline and friends missing argument vp = NULL ? #1

bryanhanson opened this issue Aug 9, 2017 · 3 comments

Comments

@bryanhanson
Copy link

bryanhanson commented Aug 9, 2017

Hi Paul. Nice package, I'm putting it to use.

Not sure if this is intentional, but it looks like none of the functions that actually draw something include the argument vp = NULL. In grid all drawing functions include this argument, which of course saves some extra steps. Perhaps this applies to the *Grob functions too.

@pmur002
Copy link
Owner

pmur002 commented Aug 9, 2017

Hi. Great to hear that someone is using it :) I would be interested to see your final result if you are happy/able to share.

Thanks for pointing out the 'vp' issue. Pure oversight on my part. I will put it on my list to add (I don't think there are any good reasons not to).

@bryanhanson
Copy link
Author

My use is not exactly technical -- I'm building a variation of the kandinsky package. I remembered reading about vwline and I'm experimenting with different variations on splines to add to the paintings -- just some on the side fun.

@pmur002
Copy link
Owner

pmur002 commented Aug 9, 2017

Ah! I saw that the other day. Good fun, and I can see how some more natural looking curves might help.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants