Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

type errors on addEventListener for any class that extends from EventDispatcher #387

Open
RodrigoHamuy opened this issue Nov 28, 2024 · 0 comments
Labels
bug Something isn't working

Comments

@RodrigoHamuy
Copy link
Contributor

  • @types/three version: from 0.168.0
  • three-stdlib version: 2.34.0

Problem description:

@types/three introduced on v168 the breaking change that unknown events can no longer be dispatched in EventDispatcher (source).

Relevant code:

So now this will throw TS errors:

import { OrbitControls } from "three-stdlib";

const orbit = new OrbitControls();

orbit.addEventListener("start", ()=> console.log('started'));
// Argument of type 'string' is not assignable to parameter of type 'never'.

Suggested solution:

One easy way would be to upgrade @types/three and then update any classes that extend from EventDispatcher.

But I don't think that will work if we want to maintain backward compatibility?

Another option is to maintain a copy of the latest EventDispatcher and use that instead? I guess that would sort backwards compatibility?

@RodrigoHamuy RodrigoHamuy added the bug Something isn't working label Nov 28, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

1 participant