Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Document and sync parameters for each model #39

Open
3 tasks
pmhalvor opened this issue Apr 4, 2022 · 0 comments
Open
3 tasks

Document and sync parameters for each model #39

pmhalvor opened this issue Apr 4, 2022 · 0 comments

Comments

@pmhalvor
Copy link
Owner

pmhalvor commented Apr 4, 2022

My models make use of unspecified **kwargs and a self.find() function for flexibility.

However, params used in mulitple places in same model, init_components() and forward(), could possible have different defaults.

In the doc-strings for each model, specify which parameters the model uses, i.e. that can be defined in configs. Also, sync defaults across all methods within that class.

Checklist:

  • doc string explain parameter w/ default
  • sync defaults between all methods
  • double check params in inherited methods (i.e. BertHead, IMN, evt. children of FgFlex)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant