Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix for 2.2.5 #20

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Fix for 2.2.5 #20

wants to merge 1 commit into from

Conversation

cdhowie
Copy link

@cdhowie cdhowie commented Jul 19, 2024

Fix building newer versions of liquidsoap that require a newer opam (fixes #19), add ffmpeg, ssl (supersedes #13), and jemalloc support, fix OCaml version to 4.14.2 to avoid GC issues with 5.x that result in roughly double the peak memory usage.

@cdhowie
Copy link
Author

cdhowie commented Jul 20, 2024

The two-stage build appears to break liquidsoap as there are some files from the build environment that are needed for it to run. (See savonet/liquidsoap#4044)

Switch from ubuntu:focal to debian:bookworm-slim for smaller image and newer
opam.

Add ffmpeg, ssl, and jemalloc support.

Fix OCaml version to 4.14.2 to avoid GC issues with 5.x.
@cdhowie cdhowie changed the title Overhaul Dockerfile Fix for 2.2.5 Jul 27, 2024
@cdhowie cdhowie marked this pull request as ready for review July 27, 2024 12:51
@cdhowie
Copy link
Author

cdhowie commented Jul 27, 2024

I've reverted to a one-stage build for now. Two-stage can be done as a separate PR.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Fails to build for liquidsoap 2.2.5
1 participant