Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Any blocker not to bump to last majors of d3-*? #2305

Closed
dubzzz opened this issue Apr 26, 2023 · 5 comments
Closed

Any blocker not to bump to last majors of d3-*? #2305

dubzzz opened this issue Apr 26, 2023 · 5 comments

Comments

@dubzzz
Copy link
Contributor

dubzzz commented Apr 26, 2023

Is your feature request related to a problem? Please describe.

Yes and no. I observed that nivo was pulling multiple versions of some d3- packages. While trying to suggest changes to dedupe them I detected that many d3- dependencies was outdated by several majors.

Describe the solution you'd like

Bumping to latest major of d3-.

Describe alternatives you've considered

Keep it that way.

Additional context

Before opening any PR in that direction I wanted to confirm that it would be ok to go in that direction.

@dubzzz dubzzz changed the title Blocker to bump to last majors of d3-*? Any blocker not to bump to last majors of d3-*? Apr 26, 2023
@plouc
Copy link
Owner

plouc commented Apr 26, 2023

First, the fact that D3 packages moved to esm, also that D3 now requires a browser that supports ES2015. That being said, I already had to upgrade d3-color due to a security issue, so it would be a continuation of this update. Other than that, just the fact that D3 APIs have changed and nivo doesn't have a consistent code coverage depending on the package. We can see a summary of the changes per major here, and there are a few breaking changes.

@dubzzz
Copy link
Contributor Author

dubzzz commented Apr 26, 2023

Indeed the esm-only is a huge blocker 😢

@plouc
Copy link
Owner

plouc commented Apr 26, 2023

Yea, but I think we need to move forward anyway, other libraries relying on D3 faced the same issue, victory explained the issue in details here, but the infrastructure of nivo is already complex enough, I'd like to avoid to have to transpile and vendor D3 dependencies.

@plouc
Copy link
Owner

plouc commented Apr 27, 2023

Seems like visx is also struggling with this...

@plouc
Copy link
Owner

plouc commented Apr 27, 2023

I'm closing this as the main roadblock is now described in this issue: #2310.

@plouc plouc closed this as completed Apr 27, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants