Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

RE: Great! #96

Closed
aboulang opened this issue Feb 19, 2020 · 1 comment
Closed

RE: Great! #96

aboulang opened this issue Feb 19, 2020 · 1 comment

Comments

@aboulang
Copy link

aboulang commented Feb 19, 2020

Nicolas,

See #93 and #94 for bugs in react-pivottable but do not exist in pivottable.js. Also, how does one add an extension like Subtotal.js to react-pivottable?

Originally posted by @nicolaskruchten in #95 (comment)

@nicolaskruchten
Copy link
Contributor

OK, thanks!

Subtotal.js is a third-party project that's not maintained by me and is incompatible with react-pivottable, as it's not react-based... Basically you'd need to write a new renderer for react-pivottable that does this subtotal stuff.

There is an open PR here #79 but it's too hard to review as-is and I've asked for it to be broken up into smaller, easier-to-merge pieces but I've gotten no uptake on that.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants