From 8d010c00d8e4e9e8f0b72fb87bc03e1d2ae1017a Mon Sep 17 00:00:00 2001 From: Mojtaba Samimi Date: Thu, 17 Oct 2024 11:52:02 -0400 Subject: [PATCH 1/7] drop deprecated autotick from cartesian axes --- src/plot_api/helpers.js | 9 --------- src/plots/cartesian/layout_attributes.js | 12 ------------ src/plots/cartesian/set_convert.js | 2 +- src/plots/gl3d/layout/tick_marks.js | 6 +++--- 4 files changed, 4 insertions(+), 25 deletions(-) diff --git a/src/plot_api/helpers.js b/src/plot_api/helpers.js index ff8ca40c986..636d9617e19 100644 --- a/src/plot_api/helpers.js +++ b/src/plot_api/helpers.js @@ -81,15 +81,6 @@ exports.cleanLayout = function(layout) { // prune empty domain arrays made before the new nestedProperty if(emptyContainer(ax, 'domain')) delete ax.domain; - - // autotick -> tickmode - if(ax.autotick !== undefined) { - if(ax.tickmode === undefined) { - ax.tickmode = ax.autotick ? 'auto' : 'linear'; - } - delete ax.autotick; - } - } } diff --git a/src/plots/cartesian/layout_attributes.js b/src/plots/cartesian/layout_attributes.js index e52643debd4..32afc99457a 100644 --- a/src/plots/cartesian/layout_attributes.js +++ b/src/plots/cartesian/layout_attributes.js @@ -1230,16 +1230,4 @@ module.exports = { ].join(' ') }, editType: 'calc', - - _deprecated: { - autotick: { - valType: 'boolean', - editType: 'ticks', - description: [ - 'Obsolete.', - 'Set `tickmode` to *auto* for old `autotick` *true* behavior.', - 'Set `tickmode` to *linear* for `autotick` *false*.' - ].join(' ') - }, - } }; diff --git a/src/plots/cartesian/set_convert.js b/src/plots/cartesian/set_convert.js index 14f17f9c2aa..a51ff198456 100644 --- a/src/plots/cartesian/set_convert.js +++ b/src/plots/cartesian/set_convert.js @@ -58,7 +58,7 @@ function isValidCategory(v) { * Creates/updates these conversion functions, and a few more utilities * like cleanRange, and makeCalcdata * - * also clears the autotick constraints ._minDtick, ._forceTick0 + * also clears ._minDtick, ._forceTick0 */ module.exports = function setConvert(ax, fullLayout) { fullLayout = fullLayout || {}; diff --git a/src/plots/gl3d/layout/tick_marks.js b/src/plots/gl3d/layout/tick_marks.js index e45e93cb8b0..f0c2b6e6a37 100644 --- a/src/plots/gl3d/layout/tick_marks.js +++ b/src/plots/gl3d/layout/tick_marks.js @@ -52,9 +52,9 @@ function computeTickMarks(scene) { axes.range[1] += 1; } // this is necessary to short-circuit the 'y' handling - // in autotick part of calcTicks... Treating all axes as 'y' in this case - // running the autoticks here, then setting - // autoticks to false to get around the 2D handling in calcTicks. + // in tickmode part of calcTicks... Treating all axes as 'y' in this case + // running the tickmode here, then setting + // automode to linear to get around the 2D handling in calcTicks. var tickModeCached = axes.tickmode; if(axes.tickmode === 'auto') { axes.tickmode = 'linear'; From 0d02ec4bfd02f940766b4bd206d72ce452eb301f Mon Sep 17 00:00:00 2001 From: Mojtaba Samimi Date: Thu, 17 Oct 2024 11:52:28 -0400 Subject: [PATCH 2/7] update schema --- test/plot-schema.json | 14 -------------- 1 file changed, 14 deletions(-) diff --git a/test/plot-schema.json b/test/plot-schema.json index 95993565185..288edc9ad86 100644 --- a/test/plot-schema.json +++ b/test/plot-schema.json @@ -13427,13 +13427,6 @@ "valType": "number" }, "xaxis": { - "_deprecated": { - "autotick": { - "description": "Obsolete. Set `tickmode` to *auto* for old `autotick` *true* behavior. Set `tickmode` to *linear* for `autotick` *false*.", - "editType": "ticks", - "valType": "boolean" - } - }, "_isSubplotObj": true, "anchor": { "description": "If set to an opposite-letter axis id (e.g. `x2`, `y`), this axis is bound to the corresponding opposite-letter axis. If set to *free*, this axis' position is determined by `position`.", @@ -14979,13 +14972,6 @@ } }, "yaxis": { - "_deprecated": { - "autotick": { - "description": "Obsolete. Set `tickmode` to *auto* for old `autotick` *true* behavior. Set `tickmode` to *linear* for `autotick` *false*.", - "editType": "ticks", - "valType": "boolean" - } - }, "_isSubplotObj": true, "anchor": { "description": "If set to an opposite-letter axis id (e.g. `x2`, `y`), this axis is bound to the corresponding opposite-letter axis. If set to *free*, this axis' position is determined by `position`.", From e048e568b00913cdde7fcae92d9b4c48533a00aa Mon Sep 17 00:00:00 2001 From: Mojtaba Samimi Date: Thu, 17 Oct 2024 11:59:47 -0400 Subject: [PATCH 3/7] autotick:true > tickmode:auto --- test/image/mocks/11.json | 4 ++-- test/image/mocks/12.json | 4 ++-- test/image/mocks/13.json | 4 ++-- test/image/mocks/14.json | 4 ++-- test/image/mocks/15.json | 2 +- test/image/mocks/17.json | 4 ++-- test/image/mocks/18.json | 12 ++++++------ test/image/mocks/19.json | 8 ++++---- test/image/mocks/21.json | 2 +- test/image/mocks/22.json | 4 ++-- test/image/mocks/23.json | 4 ++-- test/image/mocks/24.json | 4 ++-- test/image/mocks/25.json | 4 ++-- test/image/mocks/26.json | 4 ++-- test/image/mocks/27.json | 4 ++-- test/image/mocks/28.json | 2 +- test/image/mocks/29.json | 4 ++-- test/image/mocks/30.json | 4 ++-- test/image/mocks/31.json | 4 ++-- test/image/mocks/32.json | 4 ++-- test/image/mocks/axes_booleans.json | 4 ++-- test/image/mocks/contour_match_edges.json | 4 ++-- test/image/mocks/gl2d_10.json | 4 ++-- test/image/mocks/gl2d_12.json | 4 ++-- test/image/mocks/gl2d_14.json | 4 ++-- test/image/mocks/gl2d_17.json | 4 ++-- test/image/mocks/gl2d_axes_booleans.json | 4 ++-- test/image/mocks/gl2d_fonts.json | 4 ++-- test/image/mocks/gl3d_opacity-surface.json | 6 +++--- test/image/mocks/japanese.json | 4 ++-- test/image/mocks/legend_horizontal.json | 4 ++-- 31 files changed, 66 insertions(+), 66 deletions(-) diff --git a/test/image/mocks/11.json b/test/image/mocks/11.json index e2f8a7ce60c..7fb5138cf6e 100644 --- a/test/image/mocks/11.json +++ b/test/image/mocks/11.json @@ -96,7 +96,7 @@ "showgrid": true, "zeroline": false, "showline": false, - "autotick": true, + "tickmode": "auto", "nticks": 0, "ticks": "", "showticklabels": true, @@ -140,7 +140,7 @@ "showgrid": true, "zeroline": false, "showline": false, - "autotick": true, + "tickmode": "auto", "nticks": 0, "ticks": "", "showticklabels": true, diff --git a/test/image/mocks/12.json b/test/image/mocks/12.json index 1cf5980cdc4..4749f1eb08e 100644 --- a/test/image/mocks/12.json +++ b/test/image/mocks/12.json @@ -376,7 +376,7 @@ "showgrid": false, "zeroline": false, "showline": true, - "autotick": true, + "tickmode": "auto", "nticks": 0, "ticks": "", "showticklabels": true, @@ -416,7 +416,7 @@ "showgrid": false, "zeroline": false, "showline": true, - "autotick": true, + "tickmode": "auto", "nticks": 0, "ticks": "", "showticklabels": true, diff --git a/test/image/mocks/13.json b/test/image/mocks/13.json index 528dbb99e58..bd910df9e0b 100644 --- a/test/image/mocks/13.json +++ b/test/image/mocks/13.json @@ -232,7 +232,7 @@ "showgrid": true, "zeroline": true, "showline": true, - "autotick": true, + "tickmode": "auto", "nticks": 13, "ticks": "", "showticklabels": true, @@ -272,7 +272,7 @@ "showgrid": true, "zeroline": true, "showline": true, - "autotick": true, + "tickmode": "auto", "nticks": 13, "ticks": "", "showticklabels": true, diff --git a/test/image/mocks/14.json b/test/image/mocks/14.json index 5e750eef772..f5ef2feef6b 100644 --- a/test/image/mocks/14.json +++ b/test/image/mocks/14.json @@ -54,7 +54,7 @@ "showgrid": true, "zeroline": true, "showline": false, - "autotick": true, + "tickmode": "auto", "nticks": 40, "ticks": "", "showticklabels": true, @@ -95,7 +95,7 @@ "showgrid": true, "zeroline": true, "showline": false, - "autotick": true, + "tickmode": "auto", "nticks": 6, "ticks": "", "showticklabels": true, diff --git a/test/image/mocks/15.json b/test/image/mocks/15.json index 187a4dbb5f5..11933fa37eb 100644 --- a/test/image/mocks/15.json +++ b/test/image/mocks/15.json @@ -170,7 +170,7 @@ "showgrid": false, "zeroline": true, "showline": false, - "autotick": true, + "tickmode": "auto", "nticks": 0, "ticks": "outside", "showticklabels": true, diff --git a/test/image/mocks/17.json b/test/image/mocks/17.json index 9ff992367c7..cf28a965dc5 100644 --- a/test/image/mocks/17.json +++ b/test/image/mocks/17.json @@ -494,7 +494,7 @@ "showgrid": true, "zeroline": true, "showline": false, - "autotick": true, + "tickmode": "auto", "nticks": 0, "ticks": "outside", "showticklabels": true, @@ -538,7 +538,7 @@ "showgrid": true, "zeroline": true, "showline": false, - "autotick": true, + "tickmode": "auto", "nticks": 0, "ticks": "outside", "showticklabels": true, diff --git a/test/image/mocks/18.json b/test/image/mocks/18.json index 8fd95606b0b..0d1cd23940c 100644 --- a/test/image/mocks/18.json +++ b/test/image/mocks/18.json @@ -1127,7 +1127,7 @@ "showgrid": true, "zeroline": false, "showline": false, - "autotick": true, + "tickmode": "auto", "nticks": 0, "ticks": "", "showticklabels": true, @@ -1170,7 +1170,7 @@ "showgrid": true, "zeroline": false, "showline": false, - "autotick": true, + "tickmode": "auto", "nticks": 0, "ticks": "", "showticklabels": true, @@ -1242,7 +1242,7 @@ "showgrid": true, "zeroline": false, "showline": false, - "autotick": true, + "tickmode": "auto", "nticks": 0, "ticks": "", "showticklabels": true, @@ -1285,7 +1285,7 @@ "showgrid": true, "zeroline": false, "showline": false, - "autotick": true, + "tickmode": "auto", "nticks": 0, "ticks": "", "showticklabels": true, @@ -1328,7 +1328,7 @@ "showgrid": true, "zeroline": false, "showline": false, - "autotick": true, + "tickmode": "auto", "nticks": 0, "ticks": "", "showticklabels": true, @@ -1371,7 +1371,7 @@ "showgrid": true, "zeroline": false, "showline": false, - "autotick": true, + "tickmode": "auto", "nticks": 0, "ticks": "", "showticklabels": true, diff --git a/test/image/mocks/19.json b/test/image/mocks/19.json index 5e9f18d11c6..7d6c8cc30b9 100644 --- a/test/image/mocks/19.json +++ b/test/image/mocks/19.json @@ -51,7 +51,7 @@ "showgrid": true, "zeroline": true, "showline": false, - "autotick": true, + "tickmode": "auto", "nticks": 0, "ticks": "", "showticklabels": true, @@ -92,7 +92,7 @@ "showgrid": true, "zeroline": true, "showline": false, - "autotick": true, + "tickmode": "auto", "nticks": 0, "ticks": "", "showticklabels": true, @@ -165,7 +165,7 @@ "showgrid": true, "zeroline": true, "showline": false, - "autotick": true, + "tickmode": "auto", "nticks": 0, "ticks": "", "showticklabels": true, @@ -205,7 +205,7 @@ "showgrid": true, "zeroline": true, "showline": false, - "autotick": true, + "tickmode": "auto", "nticks": 0, "ticks": "", "showticklabels": true, diff --git a/test/image/mocks/21.json b/test/image/mocks/21.json index c9029ac3862..5c1367abd1c 100644 --- a/test/image/mocks/21.json +++ b/test/image/mocks/21.json @@ -428,7 +428,7 @@ "showgrid": true, "zeroline": true, "showline": false, - "autotick": true, + "tickmode": "auto", "nticks": 0, "ticks": "outside", "showticklabels": true, diff --git a/test/image/mocks/22.json b/test/image/mocks/22.json index c4164fac101..984b0e8fbb9 100644 --- a/test/image/mocks/22.json +++ b/test/image/mocks/22.json @@ -180,7 +180,7 @@ "showgrid": true, "zeroline": true, "showline": false, - "autotick": true, + "tickmode": "auto", "nticks": 0, "ticks": "outside", "showticklabels": true, @@ -220,7 +220,7 @@ "showgrid": true, "zeroline": true, "showline": false, - "autotick": true, + "tickmode": "auto", "nticks": 0, "ticks": "outside", "showticklabels": true, diff --git a/test/image/mocks/23.json b/test/image/mocks/23.json index 38904ba8f5e..b5387e4b8ca 100644 --- a/test/image/mocks/23.json +++ b/test/image/mocks/23.json @@ -44,7 +44,7 @@ "showgrid": false, "zeroline": false, "showline": false, - "autotick": true, + "tickmode": "auto", "nticks": 0, "ticks": "", "showticklabels": true, @@ -84,7 +84,7 @@ "showgrid": true, "zeroline": true, "showline": false, - "autotick": true, + "tickmode": "auto", "nticks": 0, "ticks": "", "showticklabels": true, diff --git a/test/image/mocks/24.json b/test/image/mocks/24.json index 933533f1729..9ed399acc0f 100644 --- a/test/image/mocks/24.json +++ b/test/image/mocks/24.json @@ -75,7 +75,7 @@ "showgrid": true, "zeroline": true, "showline": false, - "autotick": true, + "tickmode": "auto", "nticks": 0, "ticks": "", "showticklabels": true, @@ -123,7 +123,7 @@ "showgrid": true, "zeroline": true, "showline": false, - "autotick": true, + "tickmode": "auto", "nticks": 0, "ticks": "", "showticklabels": true, diff --git a/test/image/mocks/25.json b/test/image/mocks/25.json index 7ed938bcbba..b46dc9d1620 100644 --- a/test/image/mocks/25.json +++ b/test/image/mocks/25.json @@ -82,7 +82,7 @@ "showgrid": true, "zeroline": true, "showline": false, - "autotick": true, + "tickmode": "auto", "nticks": 16, "ticks": "", "showticklabels": true, @@ -122,7 +122,7 @@ "showgrid": true, "zeroline": true, "showline": false, - "autotick": true, + "tickmode": "auto", "nticks": 16, "ticks": "", "showticklabels": true, diff --git a/test/image/mocks/26.json b/test/image/mocks/26.json index 1792940d61d..80352f87f49 100644 --- a/test/image/mocks/26.json +++ b/test/image/mocks/26.json @@ -20995,7 +20995,7 @@ "showgrid": true, "zeroline": true, "showline": false, - "autotick": true, + "tickmode": "auto", "nticks": 0, "ticks": "", "showticklabels": true, @@ -21035,7 +21035,7 @@ "showgrid": true, "zeroline": true, "showline": false, - "autotick": true, + "tickmode": "auto", "nticks": 0, "ticks": "", "showticklabels": true, diff --git a/test/image/mocks/27.json b/test/image/mocks/27.json index 3416d09ffc8..3ffbe7bdee8 100644 --- a/test/image/mocks/27.json +++ b/test/image/mocks/27.json @@ -215,7 +215,7 @@ "showgrid": false, "zeroline": true, "showline": true, - "autotick": true, + "tickmode": "auto", "nticks": 0, "ticks": "outside", "showticklabels": true, @@ -255,7 +255,7 @@ "showgrid": true, "zeroline": false, "showline": true, - "autotick": true, + "tickmode": "auto", "nticks": 0, "ticks": "", "showticklabels": true, diff --git a/test/image/mocks/28.json b/test/image/mocks/28.json index b5273487770..bea33cb1bb6 100644 --- a/test/image/mocks/28.json +++ b/test/image/mocks/28.json @@ -901,7 +901,7 @@ "showgrid": false, "zeroline": true, "showline": true, - "autotick": true, + "tickmode": "auto", "nticks": 0, "ticks": "outside", "showticklabels": true, diff --git a/test/image/mocks/29.json b/test/image/mocks/29.json index 2c982dc0565..2ea907d75a4 100644 --- a/test/image/mocks/29.json +++ b/test/image/mocks/29.json @@ -2140,7 +2140,7 @@ "showgrid": true, "zeroline": true, "showline": false, - "autotick": true, + "tickmode": "auto", "nticks": 0, "ticks": "", "showticklabels": true, @@ -2185,7 +2185,7 @@ "showgrid": true, "zeroline": true, "showline": false, - "autotick": true, + "tickmode": "auto", "nticks": 0, "ticks": "", "showticklabels": true, diff --git a/test/image/mocks/30.json b/test/image/mocks/30.json index e90d8b7adaa..87ad43e39b9 100644 --- a/test/image/mocks/30.json +++ b/test/image/mocks/30.json @@ -98,7 +98,7 @@ "showgrid": true, "zeroline": false, "showline": false, - "autotick": true, + "tickmode": "auto", "nticks": 0, "ticks": "", "showticklabels": true, @@ -138,7 +138,7 @@ "showgrid": true, "zeroline": false, "showline": false, - "autotick": true, + "tickmode": "auto", "nticks": 0, "ticks": "", "showticklabels": true, diff --git a/test/image/mocks/31.json b/test/image/mocks/31.json index 32181867c9f..91037fef700 100644 --- a/test/image/mocks/31.json +++ b/test/image/mocks/31.json @@ -285,7 +285,7 @@ "showgrid": false, "zeroline": false, "showline": false, - "autotick": true, + "tickmode": "auto", "nticks": 0, "ticks": "", "showticklabels": true, @@ -325,7 +325,7 @@ "showgrid": true, "zeroline": false, "showline": false, - "autotick": true, + "tickmode": "auto", "nticks": 0, "ticks": "", "showticklabels": true, diff --git a/test/image/mocks/32.json b/test/image/mocks/32.json index 0fc0b8fb87c..9624b3eaa48 100644 --- a/test/image/mocks/32.json +++ b/test/image/mocks/32.json @@ -701,7 +701,7 @@ "showgrid": true, "zeroline": true, "showline": false, - "autotick": true, + "tickmode": "auto", "nticks": 0, "ticks": "", "showticklabels": true, @@ -742,7 +742,7 @@ "showgrid": true, "zeroline": true, "showline": false, - "autotick": true, + "tickmode": "auto", "nticks": 0, "ticks": "", "showticklabels": true, diff --git a/test/image/mocks/axes_booleans.json b/test/image/mocks/axes_booleans.json index 7df2731b927..8323c7df603 100644 --- a/test/image/mocks/axes_booleans.json +++ b/test/image/mocks/axes_booleans.json @@ -18,7 +18,7 @@ "showgrid": false, "zeroline": false, "showline": false, - "autotick": true, + "tickmode": "auto", "autorange": true }, "yaxis": { @@ -27,7 +27,7 @@ "showgrid": false, "zeroline": false, "showline": false, - "autotick": true, + "tickmode": "auto", "autorange": true } } diff --git a/test/image/mocks/contour_match_edges.json b/test/image/mocks/contour_match_edges.json index 1160a5bf078..13d106f16e7 100644 --- a/test/image/mocks/contour_match_edges.json +++ b/test/image/mocks/contour_match_edges.json @@ -1814,7 +1814,7 @@ "gridcolor": "#eee", "linecolor": "#444", "mirror": false, - "autotick": true, + "tickmode": "auto", "rangemode": "normal", "autorange": true, "nticks": 0, @@ -1870,7 +1870,7 @@ "gridcolor": "#eee", "linecolor": "#444", "mirror": false, - "autotick": true, + "tickmode": "auto", "rangemode": "normal", "autorange": true, "nticks": 0, diff --git a/test/image/mocks/gl2d_10.json b/test/image/mocks/gl2d_10.json index c5ab98103bf..31461576c67 100644 --- a/test/image/mocks/gl2d_10.json +++ b/test/image/mocks/gl2d_10.json @@ -49,7 +49,7 @@ "showgrid": false, "zeroline": false, "showline": false, - "autotick": true, + "tickmode": "auto", "nticks": 0, "ticks": "", "showticklabels": true, @@ -87,7 +87,7 @@ "showgrid": true, "zeroline": false, "showline": false, - "autotick": true, + "tickmode": "auto", "nticks": 0, "ticks": "", "showticklabels": true, diff --git a/test/image/mocks/gl2d_12.json b/test/image/mocks/gl2d_12.json index 65f73c33793..d158f738fb1 100644 --- a/test/image/mocks/gl2d_12.json +++ b/test/image/mocks/gl2d_12.json @@ -372,7 +372,7 @@ "showgrid": false, "zeroline": false, "showline": true, - "autotick": true, + "tickmode": "auto", "nticks": 0, "ticks": "", "showticklabels": true, @@ -413,7 +413,7 @@ "showgrid": false, "zeroline": false, "showline": true, - "autotick": true, + "tickmode": "auto", "nticks": 0, "ticks": "", "showticklabels": true, diff --git a/test/image/mocks/gl2d_14.json b/test/image/mocks/gl2d_14.json index 70e3b2dbeb6..59830f4eb8e 100644 --- a/test/image/mocks/gl2d_14.json +++ b/test/image/mocks/gl2d_14.json @@ -50,7 +50,7 @@ "showgrid": true, "zeroline": true, "showline": false, - "autotick": true, + "tickmode": "auto", "nticks": 40, "ticks": "", "showticklabels": true, @@ -88,7 +88,7 @@ "showgrid": true, "zeroline": true, "showline": false, - "autotick": true, + "tickmode": "auto", "nticks": 6, "ticks": "", "showticklabels": true, diff --git a/test/image/mocks/gl2d_17.json b/test/image/mocks/gl2d_17.json index b18bff53eee..4e2e9afc9ed 100644 --- a/test/image/mocks/gl2d_17.json +++ b/test/image/mocks/gl2d_17.json @@ -488,7 +488,7 @@ "showgrid": true, "zeroline": true, "showline": false, - "autotick": true, + "tickmode": "auto", "nticks": 0, "ticks": "outside", "showticklabels": true, @@ -526,7 +526,7 @@ "showgrid": true, "zeroline": true, "showline": false, - "autotick": true, + "tickmode": "auto", "nticks": 0, "ticks": "outside", "showticklabels": true, diff --git a/test/image/mocks/gl2d_axes_booleans.json b/test/image/mocks/gl2d_axes_booleans.json index b5b3d89edd0..dbc53442496 100644 --- a/test/image/mocks/gl2d_axes_booleans.json +++ b/test/image/mocks/gl2d_axes_booleans.json @@ -18,7 +18,7 @@ "showgrid": false, "zeroline": false, "showline": false, - "autotick": true, + "tickmode": "auto", "autorange": true }, "yaxis": { @@ -27,7 +27,7 @@ "showgrid": false, "zeroline": false, "showline": false, - "autotick": true, + "tickmode": "auto", "autorange": true } } diff --git a/test/image/mocks/gl2d_fonts.json b/test/image/mocks/gl2d_fonts.json index 44627677cb5..4a6517313f2 100644 --- a/test/image/mocks/gl2d_fonts.json +++ b/test/image/mocks/gl2d_fonts.json @@ -29,7 +29,7 @@ "showgrid": false, "zeroline": false, "showline": false, - "autotick": true, + "tickmode": "auto", "nticks": 0, "ticks": "", "showticklabels": false, @@ -67,7 +67,7 @@ "showgrid": false, "zeroline": false, "showline": false, - "autotick": true, + "tickmode": "auto", "nticks": 0, "ticks": "", "showticklabels": false, diff --git a/test/image/mocks/gl3d_opacity-surface.json b/test/image/mocks/gl3d_opacity-surface.json index e28efcd4cbd..b0d9f8130e2 100644 --- a/test/image/mocks/gl3d_opacity-surface.json +++ b/test/image/mocks/gl3d_opacity-surface.json @@ -1512,7 +1512,7 @@ }, "yaxis": { "showticklabels": false, - "autotick": true, + "tickmode": "auto", "rangemode": "normal", "autorange": true, "nticks": 0, @@ -1560,7 +1560,7 @@ "bgcolor": "rgb(67, 67, 67)", "zaxis": { "showticklabels": false, - "autotick": true, + "tickmode": "auto", "rangemode": "normal", "autorange": true, "nticks": 0, @@ -1590,7 +1590,7 @@ }, "xaxis": { "showticklabels": false, - "autotick": true, + "tickmode": "auto", "rangemode": "normal", "autorange": true, "nticks": 0, diff --git a/test/image/mocks/japanese.json b/test/image/mocks/japanese.json index 7919ee87c40..a67af95421a 100644 --- a/test/image/mocks/japanese.json +++ b/test/image/mocks/japanese.json @@ -31,7 +31,7 @@ "showgrid": false, "zeroline": false, "showline": false, - "autotick": true, + "tickmode": "auto", "nticks": 0, "ticks": "", "showticklabels": false, @@ -71,7 +71,7 @@ "showgrid": false, "zeroline": false, "showline": false, - "autotick": true, + "tickmode": "auto", "nticks": 0, "ticks": "", "showticklabels": false, diff --git a/test/image/mocks/legend_horizontal.json b/test/image/mocks/legend_horizontal.json index 071f6696204..0be6b89d0d1 100644 --- a/test/image/mocks/legend_horizontal.json +++ b/test/image/mocks/legend_horizontal.json @@ -42,7 +42,7 @@ "showgrid": false, "zeroline": false, "showline": false, - "autotick": true, + "tickmode": "auto", "nticks": 0, "ticks": "", "showticklabels": true, @@ -80,7 +80,7 @@ "showgrid": true, "zeroline": true, "showline": false, - "autotick": true, + "tickmode": "auto", "nticks": 0, "ticks": "", "showticklabels": true, From 2daa1b3deb28742aff5758a85fbc8ae95836e7d7 Mon Sep 17 00:00:00 2001 From: Mojtaba Samimi Date: Thu, 17 Oct 2024 12:00:23 -0400 Subject: [PATCH 4/7] autotick:false > tickmode:linear --- test/image/mocks/15.json | 2 +- test/image/mocks/21.json | 2 +- test/image/mocks/28.json | 2 +- test/image/mocks/axes-ticks.json | 4 ++-- test/image/mocks/geo_africa-insets.json | 8 ++++---- test/image/mocks/titles-avoid-labels.json | 6 +++--- 6 files changed, 12 insertions(+), 12 deletions(-) diff --git a/test/image/mocks/15.json b/test/image/mocks/15.json index 11933fa37eb..7b02eb58f54 100644 --- a/test/image/mocks/15.json +++ b/test/image/mocks/15.json @@ -210,7 +210,7 @@ "showgrid": true, "zeroline": true, "showline": false, - "autotick": false, + "tickmode": "linear", "nticks": 0, "ticks": "", "showticklabels": true, diff --git a/test/image/mocks/21.json b/test/image/mocks/21.json index 5c1367abd1c..6c51d6b0af4 100644 --- a/test/image/mocks/21.json +++ b/test/image/mocks/21.json @@ -388,7 +388,7 @@ "showgrid": true, "zeroline": true, "showline": false, - "autotick": false, + "tickmode": "linear", "nticks": 0, "ticks": "outside", "showticklabels": true, diff --git a/test/image/mocks/28.json b/test/image/mocks/28.json index bea33cb1bb6..428f01ebc15 100644 --- a/test/image/mocks/28.json +++ b/test/image/mocks/28.json @@ -942,7 +942,7 @@ "showgrid": true, "zeroline": false, "showline": true, - "autotick": false, + "tickmode": "linear", "nticks": 0, "ticks": "", "showticklabels": true, diff --git a/test/image/mocks/axes-ticks.json b/test/image/mocks/axes-ticks.json index 292a2b214d4..a3c7022a273 100644 --- a/test/image/mocks/axes-ticks.json +++ b/test/image/mocks/axes-ticks.json @@ -19,7 +19,7 @@ "ticklen": 8, "dtick": 0.25, "tickcolor": "#000", - "autotick": false + "tickmode": "linear" }, "yaxis": { "ticks": "outside", @@ -28,7 +28,7 @@ "ticklen": 8, "dtick": 0.25, "tickcolor": "#000", - "autotick": false, + "tickmode": "linear", "gridwidth": 0.1 } } diff --git a/test/image/mocks/geo_africa-insets.json b/test/image/mocks/geo_africa-insets.json index 6c4ab85ef40..ff8fa631052 100644 --- a/test/image/mocks/geo_africa-insets.json +++ b/test/image/mocks/geo_africa-insets.json @@ -10,7 +10,7 @@ "dtick": 1000, "colorbar": { "tickprefix": "", - "autotick": false, + "tickmode": "linear", "title": { "text": "" } }, "lat": [9.95, 6.43, 14.5, 8.46], @@ -34,7 +34,7 @@ "dtick": 1000, "colorbar": { "tickprefix": "", - "autotick": false, + "tickmode": "linear", "title": { "text": "" } }, "lat": [9.95, 6.43, 14.5, 8.46], @@ -57,7 +57,7 @@ "dtick": 1000, "colorbar": { "tickprefix": "", - "autotick": false, + "tickmode": "linear", "title": { "text": "" } }, "lat": [9.95, 6.43, 8.46], @@ -80,7 +80,7 @@ "dtick": 1000, "colorbar": { "tickprefix": "", - "autotick": false, + "tickmode": "linear", "title": { "text": "" } }, "lat": [9.95, 6.43, 8.46], diff --git a/test/image/mocks/titles-avoid-labels.json b/test/image/mocks/titles-avoid-labels.json index 4aeb506bff9..8ee88f9fe03 100644 --- a/test/image/mocks/titles-avoid-labels.json +++ b/test/image/mocks/titles-avoid-labels.json @@ -9,7 +9,7 @@ "text": "colorbar title", "side": "right" }, - "autotick": false, + "tickmode": "linear", "dtick": 0.511, "tickangle": -10 }, @@ -42,7 +42,7 @@ "gridwidth": 1, "autorange": true, "rangemode": "normal", - "autotick": false, + "tickmode": "linear", "zeroline": true, "zerolinecolor": "#444", "zerolinewidth": 1, @@ -87,7 +87,7 @@ "gridwidth": 1, "autorange": true, "rangemode": "normal", - "autotick": false, + "tickmode": "linear", "zeroline": true, "zerolinecolor": "#444", "zerolinewidth": 1, From f205bb4e613e3ba7c0647d80e4da6905a293de39 Mon Sep 17 00:00:00 2001 From: Mojtaba Samimi Date: Thu, 17 Oct 2024 12:57:19 -0400 Subject: [PATCH 5/7] gl3d_opacity-surface needed different adjustment --- test/image/mocks/gl3d_opacity-surface.json | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/test/image/mocks/gl3d_opacity-surface.json b/test/image/mocks/gl3d_opacity-surface.json index b0d9f8130e2..bbb4431cd12 100644 --- a/test/image/mocks/gl3d_opacity-surface.json +++ b/test/image/mocks/gl3d_opacity-surface.json @@ -1512,7 +1512,7 @@ }, "yaxis": { "showticklabels": false, - "tickmode": "auto", + "tickmode": "linear", "rangemode": "normal", "autorange": true, "nticks": 0, @@ -1560,7 +1560,7 @@ "bgcolor": "rgb(67, 67, 67)", "zaxis": { "showticklabels": false, - "tickmode": "auto", + "tickmode": "linear", "rangemode": "normal", "autorange": true, "nticks": 0, @@ -1590,7 +1590,7 @@ }, "xaxis": { "showticklabels": false, - "tickmode": "auto", + "tickmode": "linear", "rangemode": "normal", "autorange": true, "nticks": 0, From a6a5f58a6ef92d63322c3546116d0b22249a1efe Mon Sep 17 00:00:00 2001 From: Mojtaba Samimi Date: Thu, 17 Oct 2024 13:47:29 -0400 Subject: [PATCH 6/7] PR log --- draftlogs/7236_remove.md | 1 + 1 file changed, 1 insertion(+) create mode 100644 draftlogs/7236_remove.md diff --git a/draftlogs/7236_remove.md b/draftlogs/7236_remove.md new file mode 100644 index 00000000000..41e494f7734 --- /dev/null +++ b/draftlogs/7236_remove.md @@ -0,0 +1 @@ + - Drop deprecated autotick attributes from cartesian and gl3d axes [[#7236](https://github.com/plotly/plotly.js/pull/7236)] From 61ac98ff242a76233a2d6cf69e04aeb7f68f71b9 Mon Sep 17 00:00:00 2001 From: Mojtaba Samimi Date: Thu, 17 Oct 2024 13:55:18 -0400 Subject: [PATCH 7/7] some of these blacklisted mocks now pass the validate test --- tasks/test_mock.mjs | 3 --- 1 file changed, 3 deletions(-) diff --git a/tasks/test_mock.mjs b/tasks/test_mock.mjs index 360e238b0c4..3b6be238a5b 100644 --- a/tasks/test_mock.mjs +++ b/tasks/test_mock.mjs @@ -144,9 +144,7 @@ function notBlackListed(name) { '32', 'annotations', 'annotations-autorange', - 'axes_booleans', 'axes_labels', - 'axes-ticks', 'candlestick_double-y-axis', 'candlestick_rangeslider_thai', 'category-autorange', @@ -163,7 +161,6 @@ function notBlackListed(name) { 'gl2d_14', 'gl2d_17', 'gl2d_annotations', - 'gl2d_axes_booleans', 'gl2d_axes_labels', 'gl2d_fill_trace_tozero_order', 'gl2d_fonts',