Module names are too restrictive

[tfcollins]

dash-component-boilerplate/hooks/pre_gen_project.py

Line 27 in c59567c

def _check_specials_characters(s):

I think this check is too restrictive as Python modules should be able to contain numbers just not start with them. PEP8 isn't super clear though: https://www.python.org/dev/peps/pep-0008/#package-and-module-names

[alexcjohnson]

Good catch @tfcollins - we should certainly accept numbers after the first character. Feel like making a PR?

In fact I don't think even the lowercase restriction is necessary, just conventional. I believe any Python identifier is valid as a module name, ie [a-zA-Z_][a-zA-Z0-9_]*. That said I don't see any prominent examples of uppercase letters in module names whereas numbers do appear from time to time, so just adding numbers is probably the right thing to do here.

[tfcollins]

I'll try to put together a PR in a few days. Based on my reading a PEP8 I'll change the check to assume all lowercase, cannot start with a number, and underscores cannot be on either end of name.

-Travis

[elda27]

Any update here?