Skip to content

Commit

Permalink
pin duckdb
Browse files Browse the repository at this point in the history
  • Loading branch information
neelasha23 committed Mar 25, 2024
1 parent 28bfb38 commit 272856c
Show file tree
Hide file tree
Showing 2 changed files with 4 additions and 19 deletions.
6 changes: 4 additions & 2 deletions setup.py
Original file line number Diff line number Diff line change
Expand Up @@ -19,7 +19,8 @@
"prettytable",
# IPython dropped support for Python 3.8
"ipython<=8.12.0; python_version <= '3.8'",
"sqlalchemy==2.0.28",
# sqlalchemy 2.0.29 breaking the CI: https://github.com/ploomber/jupysql/issues/1001
"sqlalchemy<2.0.29",
"sqlparse",
"ipython-genutils>=0.1.0",
"jinja2",
Expand All @@ -42,7 +43,8 @@
"pkgmt",
"twine",
# tests
"duckdb",
# DuckDB 0.10.1 breaking Sqlalchemy v1 tests: https://github.com/ploomber/jupysql/issues/1001 # noqa
"duckdb<0.10.1",
"duckdb-engine",
"pyodbc",
# sql.plot module tests
Expand Down
17 changes: 0 additions & 17 deletions src/tests/test_magic.py
Original file line number Diff line number Diff line change
Expand Up @@ -2767,20 +2767,3 @@ def test_disabled_named_parameters_shows_disabled_warning(ip):
)

assert expected_warning in str(excinfo.value)


def test_disabled_named_parameters_shows_disabled_warning_duplicate(ip):
ip.run_cell("%config SqlMagic.named_parameters='disabled'")
query_should_warn = "%sql select json('[{\"a\"::1}')"

with pytest.raises(UsageError) as excinfo:
ip.run_cell(query_should_warn)

expected_warning = (
'The named parameters feature is "disabled". '
'Enable it with: %config SqlMagic.named_parameters="enabled".\n'
"For more info, see the docs: "
"https://jupysql.ploomber.io/en/latest/api/configuration.html"
)

assert expected_warning in str(excinfo.value)

0 comments on commit 272856c

Please sign in to comment.