Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve highlighting for aggregate functions #10

Open
jorisroovers opened this issue Apr 6, 2023 · 0 comments
Open

Improve highlighting for aggregate functions #10

jorisroovers opened this issue Apr 6, 2023 · 0 comments

Comments

@jorisroovers
Copy link

Like SUM, AVG, etc.

While these tend to be database specific, there are also a bunch that are almost universally supported.

Example reference from DuckDB: https://duckdb.org/docs/sql/aggregates

Similar comment wrt highlighting other functions, eg: https://duckdb.org/docs/sql/functions/overview

Haven't looked at the source so not sure if it's easy to do different highlighting depending on different SQL dialects (perhaps this can be discovered and/or configurable?).

Regardless of dialect, I think it's pretty safe to always highlight the most commonly supported aggregate functions (like SUM, AVG, COUNT, etc). Perhaps in a different color than other SQL keywords?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant