From 0ed8cc4c987ae409bcf3fe93262d1dbc988c3bd1 Mon Sep 17 00:00:00 2001 From: mauritsvanrees Date: Mon, 2 Sep 2024 16:34:09 +0200 Subject: [PATCH] [fc] Repository: plone.app.discussion Branch: refs/heads/4.x Date: 2024-08-19T15:01:31+02:00 Author: Gil Forcada Codinachs (gforcada) Commit: https://github.com/plone/plone.app.discussion/commit/c0cba64999f2a1bd717cf2352be421ed69513890 Add missing icon The `view` action of comments had no icon on Plone 6. Files changed: M plone/app/discussion/profiles/default/types/Discussion_Item.xml Repository: plone.app.discussion Branch: refs/heads/4.x Date: 2024-08-19T15:01:31+02:00 Author: Gil Forcada Codinachs (gforcada) Commit: https://github.com/plone/plone.app.discussion/commit/3c5f4570dcc625c54b5da5606b47f83a6885f163 Add news entry Files changed: A news/+ignore.bugfix Repository: plone.app.discussion Branch: refs/heads/4.x Date: 2024-08-19T16:21:53+02:00 Author: Maurits van Rees (mauritsvanrees) Commit: https://github.com/plone/plone.app.discussion/commit/6983e3505b4985f9f15a1800467aecf1e5078acd Register contenttype icon. Add upgrade step for updating the icons. Files changed: A news/222.bugfix A plone/app/discussion/profiles/to_2002/registry.xml A plone/app/discussion/profiles/to_2002/types/Discussion_Item.xml A plone/app/discussion/setuphandlers.py M plone/app/discussion/configure.zcml M plone/app/discussion/profiles/default/metadata.xml M plone/app/discussion/profiles/default/registry.xml M plone/app/discussion/profiles/default/types/Discussion_Item.xml M plone/app/discussion/upgrades.zcml D news/+ignore.bugfix Repository: plone.app.discussion Branch: refs/heads/4.x Date: 2024-08-19T16:29:55+02:00 Author: Maurits van Rees (mauritsvanrees) Commit: https://github.com/plone/plone.app.discussion/commit/7b599163bed9cc58f21653172afe3371f7b9477c zpretty Files changed: M plone/app/discussion/profiles/default/types/Discussion_Item.xml M plone/app/discussion/profiles/to_2002/types/Discussion_Item.xml Repository: plone.app.discussion Branch: refs/heads/4.x Date: 2024-08-21T12:20:51+02:00 Author: Maurits van Rees (mauritsvanrees) Commit: https://github.com/plone/plone.app.discussion/commit/f71e608714cef1bb0f2e1539b66b96f3daf652c8 Fix copy-paste leftover. Files changed: M plone/app/discussion/setuphandlers.py Repository: plone.app.discussion Branch: refs/heads/4.x Date: 2024-09-02T16:34:09+02:00 Author: Maurits van Rees (mauritsvanrees) Commit: https://github.com/plone/plone.app.discussion/commit/512d53bdbd5bf95fa76a728c45b1106b97543770 Merge pull request #222 from plone/gforcada-patch-2 Add missing icon Files changed: A news/222.bugfix A plone/app/discussion/profiles/to_2002/registry.xml A plone/app/discussion/profiles/to_2002/types/Discussion_Item.xml A plone/app/discussion/setuphandlers.py M plone/app/discussion/configure.zcml M plone/app/discussion/profiles/default/metadata.xml M plone/app/discussion/profiles/default/registry.xml M plone/app/discussion/profiles/default/types/Discussion_Item.xml M plone/app/discussion/upgrades.zcml --- last_commit.txt | 112 ++++++++++++++++++++++++++++++++++++++++-------- 1 file changed, 94 insertions(+), 18 deletions(-) diff --git a/last_commit.txt b/last_commit.txt index 91eae07603..93da32f38c 100644 --- a/last_commit.txt +++ b/last_commit.txt @@ -1,36 +1,112 @@ -Repository: Products.CMFPlone +Repository: plone.app.discussion -Branch: refs/heads/6.0.x -Date: 2024-08-29T20:43:39+02:00 +Branch: refs/heads/4.x +Date: 2024-08-19T15:01:31+02:00 +Author: Gil Forcada Codinachs (gforcada) +Commit: https://github.com/plone/plone.app.discussion/commit/c0cba64999f2a1bd717cf2352be421ed69513890 + +Add missing icon + +The `view` action of comments had no icon on Plone 6. + +Files changed: +M plone/app/discussion/profiles/default/types/Discussion_Item.xml + +b'diff --git a/plone/app/discussion/profiles/default/types/Discussion_Item.xml b/plone/app/discussion/profiles/default/types/Discussion_Item.xml\nindex c05efcb9..eccc9c20 100644\n--- a/plone/app/discussion/profiles/default/types/Discussion_Item.xml\n+++ b/plone/app/discussion/profiles/default/types/Discussion_Item.xml\n@@ -30,6 +30,7 @@\n condition_expr=""\n title="View"\n url_expr="string:${object_url}/@@view"\n+ icon_expr="string:toolbar-action/view"\n visible="True"\n >\n \n' + +Repository: plone.app.discussion + + +Branch: refs/heads/4.x +Date: 2024-08-19T15:01:31+02:00 +Author: Gil Forcada Codinachs (gforcada) +Commit: https://github.com/plone/plone.app.discussion/commit/3c5f4570dcc625c54b5da5606b47f83a6885f163 + +Add news entry + +Files changed: +A news/+ignore.bugfix + +b"diff --git a/news/+ignore.bugfix b/news/+ignore.bugfix\nnew file mode 100644\nindex 00000000..7f7f4e85\n--- /dev/null\n+++ b/news/+ignore.bugfix\n@@ -0,0 +1,2 @@\n+Add missing icon on comments' `view` action\n+[gforcada]\n" + +Repository: plone.app.discussion + + +Branch: refs/heads/4.x +Date: 2024-08-19T16:21:53+02:00 Author: Maurits van Rees (mauritsvanrees) -Commit: https://github.com/plone/Products.CMFPlone/commit/057d04da608164d5995ad6d1964721c782ff2009 +Commit: https://github.com/plone/plone.app.discussion/commit/6983e3505b4985f9f15a1800467aecf1e5078acd -Use five.registerPackage so an editable install with pip works. +Register contenttype icon. Add upgrade step for updating the icons. + +Files changed: +A news/222.bugfix +A plone/app/discussion/profiles/to_2002/registry.xml +A plone/app/discussion/profiles/to_2002/types/Discussion_Item.xml +A plone/app/discussion/setuphandlers.py +M plone/app/discussion/configure.zcml +M plone/app/discussion/profiles/default/metadata.xml +M plone/app/discussion/profiles/default/registry.xml +M plone/app/discussion/profiles/default/types/Discussion_Item.xml +M plone/app/discussion/upgrades.zcml +D news/+ignore.bugfix + +b'diff --git a/news/+ignore.bugfix b/news/+ignore.bugfix\ndeleted file mode 100644\nindex 7f7f4e85..00000000\n--- a/news/+ignore.bugfix\n+++ /dev/null\n@@ -1,2 +0,0 @@\n-Add missing icon on comments\' `view` action\n-[gforcada]\ndiff --git a/news/222.bugfix b/news/222.bugfix\nnew file mode 100644\nindex 00000000..6f0a228f\n--- /dev/null\n+++ b/news/222.bugfix\n@@ -0,0 +1,3 @@\n+Add missing icon on comments\' `view` action\n+Register contenttype icon for comments.\n+[gforcada, maurits]\ndiff --git a/plone/app/discussion/configure.zcml b/plone/app/discussion/configure.zcml\nindex e2b82f2d..ada1914f 100644\n--- a/plone/app/discussion/configure.zcml\n+++ b/plone/app/discussion/configure.zcml\n@@ -46,6 +46,11 @@\n for="plone.base.interfaces.IPloneSiteRoot"\n directory="profiles/default"\n />\n+ \n \n \n \ndiff --git a/plone/app/discussion/profiles/default/metadata.xml b/plone/app/discussion/profiles/default/metadata.xml\nindex 38abca6d..4cad4f61 100644\n--- a/plone/app/discussion/profiles/default/metadata.xml\n+++ b/plone/app/discussion/profiles/default/metadata.xml\n@@ -1,6 +1,6 @@\n \n \n- 2001\n+ 2002\n \n profile-plone.resource:default\n profile-plone.app.registry:default\ndiff --git a/plone/app/discussion/profiles/default/registry.xml b/plone/app/discussion/profiles/default/registry.xml\nindex 2a1aaffc..944359d3 100644\n--- a/plone/app/discussion/profiles/default/registry.xml\n+++ b/plone/app/discussion/profiles/default/registry.xml\n@@ -4,4 +4,10 @@\n False\n False\n \n+ \n+ \n+ Plone Image\n+ \n+ ++plone++bootstrap-icons/chat-left-text.svg\n+ \n \ndiff --git a/plone/app/discussion/profiles/default/types/Discussion_Item.xml b/plone/app/discussion/profiles/default/types/Discussion_Item.xml\nindex eccc9c20..01f73b0e 100644\n--- a/plone/app/discussion/profiles/default/types/Discussion_Item.xml\n+++ b/plone/app/discussion/profiles/default/types/Discussion_Item.xml\n@@ -10,7 +10,7 @@\n Comments added to a content item.\n- discussionitem_icon.png\n+ ++plone++bootstrap-icons/chat-left-text.svg\n Discussion Item\n \n plone.Comment\ndiff --git a/plone/app/discussion/profiles/to_2002/registry.xml b/plone/app/discussion/profiles/to_2002/registry.xml\nnew file mode 100644\nindex 00000000..e7886adb\n--- /dev/null\n+++ b/plone/app/discussion/profiles/to_2002/registry.xml\n@@ -0,0 +1,9 @@\n+\n+\n+ \n+ \n+ Plone Image\n+ \n+ ++plone++bootstrap-icons/chat-left-text.svg\n+ \n+\ndiff --git a/plone/app/discussion/profiles/to_2002/types/Discussion_Item.xml b/plone/app/discussion/profiles/to_2002/types/Discussion_Item.xml\nnew file mode 100644\nindex 00000000..95bbadbc\n--- /dev/null\n+++ b/plone/app/discussion/profiles/to_2002/types/Discussion_Item.xml\n@@ -0,0 +1,26 @@\n+\n+\n+ ++plone++bootstrap-icons/chat-left-text.svg\n+ \n+ \n+ \n+ \n+ \n+ \n+\ndiff --git a/plone/app/discussion/setuphandlers.py b/plone/app/discussion/setuphandlers.py\nnew file mode 100644\nindex 00000000..7b9e9c6b\n--- /dev/null\n+++ b/plone/app/discussion/setuphandlers.py\n@@ -0,0 +1,10 @@\n+from plone.base.interfaces import INonInstallable\n+from zope.interface import implementer\n+\n+\n+@implementer(INonInstallable)\n+class HiddenProfiles:\n+ def getNonInstallableProfiles(self):\n+ return [\n+ "plone.app.contenttypes:to_2002",\n+ ]\ndiff --git a/plone/app/discussion/upgrades.zcml b/plone/app/discussion/upgrades.zcml\nindex d265d428..5f716f6e 100644\n--- a/plone/app/discussion/upgrades.zcml\n+++ b/plone/app/discussion/upgrades.zcml\n@@ -108,4 +108,23 @@\n />\n \n \n+ \n+\n+ \n+ \n+ \n+\n \n' + +Repository: plone.app.discussion + + +Branch: refs/heads/4.x +Date: 2024-08-19T16:29:55+02:00 +Author: Maurits van Rees (mauritsvanrees) +Commit: https://github.com/plone/plone.app.discussion/commit/7b599163bed9cc58f21653172afe3371f7b9477c + +zpretty + +Files changed: +M plone/app/discussion/profiles/default/types/Discussion_Item.xml +M plone/app/discussion/profiles/to_2002/types/Discussion_Item.xml + +b'diff --git a/plone/app/discussion/profiles/default/types/Discussion_Item.xml b/plone/app/discussion/profiles/default/types/Discussion_Item.xml\nindex 01f73b0e..64c98c61 100644\n--- a/plone/app/discussion/profiles/default/types/Discussion_Item.xml\n+++ b/plone/app/discussion/profiles/default/types/Discussion_Item.xml\n@@ -28,9 +28,9 @@\n \n \ndiff --git a/plone/app/discussion/profiles/to_2002/types/Discussion_Item.xml b/plone/app/discussion/profiles/to_2002/types/Discussion_Item.xml\nindex 95bbadbc..92fb9496 100644\n--- a/plone/app/discussion/profiles/to_2002/types/Discussion_Item.xml\n+++ b/plone/app/discussion/profiles/to_2002/types/Discussion_Item.xml\n@@ -16,9 +16,9 @@\n \n \n' + +Repository: plone.app.discussion + + +Branch: refs/heads/4.x +Date: 2024-08-21T12:20:51+02:00 +Author: Maurits van Rees (mauritsvanrees) +Commit: https://github.com/plone/plone.app.discussion/commit/f71e608714cef1bb0f2e1539b66b96f3daf652c8 -Fixes https://github.com/plone/Products.CMFPlone/issues/4002 +Fix copy-paste leftover. Files changed: -A news/4002.bugfix -M Products/CMFPlone/configure.zcml +M plone/app/discussion/setuphandlers.py -b'diff --git a/Products/CMFPlone/configure.zcml b/Products/CMFPlone/configure.zcml\nindex efe2bac1e8..8ca804f598 100644\n--- a/Products/CMFPlone/configure.zcml\n+++ b/Products/CMFPlone/configure.zcml\n@@ -2,11 +2,13 @@\n xmlns="http://namespaces.zope.org/zope"\n xmlns:browser="http://namespaces.zope.org/browser"\n xmlns:cmf="http://namespaces.zope.org/cmf"\n+ xmlns:five="http://namespaces.zope.org/five"\n xmlns:i18n="http://namespaces.zope.org/i18n"\n xmlns:zcml="http://namespaces.zope.org/zcml"\n i18n_domain="plone"\n >\n \n+ \n \n \n \ndiff --git a/news/4002.bugfix b/news/4002.bugfix\nnew file mode 100644\nindex 0000000000..8dc1c4c0e3\n--- /dev/null\n+++ b/news/4002.bugfix\n@@ -0,0 +1,2 @@\n+Use `five.registerPackage` so an editable install with `pip` works.\n+[maurits]\n' +b'diff --git a/plone/app/discussion/setuphandlers.py b/plone/app/discussion/setuphandlers.py\nindex 7b9e9c6b..ca898bae 100644\n--- a/plone/app/discussion/setuphandlers.py\n+++ b/plone/app/discussion/setuphandlers.py\n@@ -6,5 +6,5 @@\n class HiddenProfiles:\n def getNonInstallableProfiles(self):\n return [\n- "plone.app.contenttypes:to_2002",\n+ "plone.app.discussion:to_2002",\n ]\n' -Repository: Products.CMFPlone +Repository: plone.app.discussion -Branch: refs/heads/6.0.x -Date: 2024-08-31T22:44:28+02:00 +Branch: refs/heads/4.x +Date: 2024-09-02T16:34:09+02:00 Author: Maurits van Rees (mauritsvanrees) -Commit: https://github.com/plone/Products.CMFPlone/commit/0753477e77e28c04e7f63e8598f920a66f57e6f8 +Commit: https://github.com/plone/plone.app.discussion/commit/512d53bdbd5bf95fa76a728c45b1106b97543770 -Merge pull request #4004 from plone/maurits-issue-4002-five-register-package-60 +Merge pull request #222 from plone/gforcada-patch-2 -Use five.registerPackage so an editable install with pip works. [6.0] +Add missing icon Files changed: -A news/4002.bugfix -M Products/CMFPlone/configure.zcml +A news/222.bugfix +A plone/app/discussion/profiles/to_2002/registry.xml +A plone/app/discussion/profiles/to_2002/types/Discussion_Item.xml +A plone/app/discussion/setuphandlers.py +M plone/app/discussion/configure.zcml +M plone/app/discussion/profiles/default/metadata.xml +M plone/app/discussion/profiles/default/registry.xml +M plone/app/discussion/profiles/default/types/Discussion_Item.xml +M plone/app/discussion/upgrades.zcml -b'diff --git a/Products/CMFPlone/configure.zcml b/Products/CMFPlone/configure.zcml\nindex efe2bac1e8..8ca804f598 100644\n--- a/Products/CMFPlone/configure.zcml\n+++ b/Products/CMFPlone/configure.zcml\n@@ -2,11 +2,13 @@\n xmlns="http://namespaces.zope.org/zope"\n xmlns:browser="http://namespaces.zope.org/browser"\n xmlns:cmf="http://namespaces.zope.org/cmf"\n+ xmlns:five="http://namespaces.zope.org/five"\n xmlns:i18n="http://namespaces.zope.org/i18n"\n xmlns:zcml="http://namespaces.zope.org/zcml"\n i18n_domain="plone"\n >\n \n+ \n \n \n \ndiff --git a/news/4002.bugfix b/news/4002.bugfix\nnew file mode 100644\nindex 0000000000..8dc1c4c0e3\n--- /dev/null\n+++ b/news/4002.bugfix\n@@ -0,0 +1,2 @@\n+Use `five.registerPackage` so an editable install with `pip` works.\n+[maurits]\n' +b'diff --git a/news/222.bugfix b/news/222.bugfix\nnew file mode 100644\nindex 00000000..6f0a228f\n--- /dev/null\n+++ b/news/222.bugfix\n@@ -0,0 +1,3 @@\n+Add missing icon on comments\' `view` action\n+Register contenttype icon for comments.\n+[gforcada, maurits]\ndiff --git a/plone/app/discussion/configure.zcml b/plone/app/discussion/configure.zcml\nindex e2b82f2d..ada1914f 100644\n--- a/plone/app/discussion/configure.zcml\n+++ b/plone/app/discussion/configure.zcml\n@@ -46,6 +46,11 @@\n for="plone.base.interfaces.IPloneSiteRoot"\n directory="profiles/default"\n />\n+ \n \n \n \ndiff --git a/plone/app/discussion/profiles/default/metadata.xml b/plone/app/discussion/profiles/default/metadata.xml\nindex 38abca6d..4cad4f61 100644\n--- a/plone/app/discussion/profiles/default/metadata.xml\n+++ b/plone/app/discussion/profiles/default/metadata.xml\n@@ -1,6 +1,6 @@\n \n \n- 2001\n+ 2002\n \n profile-plone.resource:default\n profile-plone.app.registry:default\ndiff --git a/plone/app/discussion/profiles/default/registry.xml b/plone/app/discussion/profiles/default/registry.xml\nindex 2a1aaffc..944359d3 100644\n--- a/plone/app/discussion/profiles/default/registry.xml\n+++ b/plone/app/discussion/profiles/default/registry.xml\n@@ -4,4 +4,10 @@\n False\n False\n \n+ \n+ \n+ Plone Image\n+ \n+ ++plone++bootstrap-icons/chat-left-text.svg\n+ \n \ndiff --git a/plone/app/discussion/profiles/default/types/Discussion_Item.xml b/plone/app/discussion/profiles/default/types/Discussion_Item.xml\nindex c05efcb9..64c98c61 100644\n--- a/plone/app/discussion/profiles/default/types/Discussion_Item.xml\n+++ b/plone/app/discussion/profiles/default/types/Discussion_Item.xml\n@@ -10,7 +10,7 @@\n Comments added to a content item.\n- discussionitem_icon.png\n+ ++plone++bootstrap-icons/chat-left-text.svg\n Discussion Item\n \n plone.Comment\n@@ -28,6 +28,7 @@\n \n+\n+ \n+ \n+ Plone Image\n+ \n+ ++plone++bootstrap-icons/chat-left-text.svg\n+ \n+\ndiff --git a/plone/app/discussion/profiles/to_2002/types/Discussion_Item.xml b/plone/app/discussion/profiles/to_2002/types/Discussion_Item.xml\nnew file mode 100644\nindex 00000000..92fb9496\n--- /dev/null\n+++ b/plone/app/discussion/profiles/to_2002/types/Discussion_Item.xml\n@@ -0,0 +1,26 @@\n+\n+\n+ ++plone++bootstrap-icons/chat-left-text.svg\n+ \n+ \n+ \n+ \n+ \n+ \n+\ndiff --git a/plone/app/discussion/setuphandlers.py b/plone/app/discussion/setuphandlers.py\nnew file mode 100644\nindex 00000000..ca898bae\n--- /dev/null\n+++ b/plone/app/discussion/setuphandlers.py\n@@ -0,0 +1,10 @@\n+from plone.base.interfaces import INonInstallable\n+from zope.interface import implementer\n+\n+\n+@implementer(INonInstallable)\n+class HiddenProfiles:\n+ def getNonInstallableProfiles(self):\n+ return [\n+ "plone.app.discussion:to_2002",\n+ ]\ndiff --git a/plone/app/discussion/upgrades.zcml b/plone/app/discussion/upgrades.zcml\nindex d265d428..5f716f6e 100644\n--- a/plone/app/discussion/upgrades.zcml\n+++ b/plone/app/discussion/upgrades.zcml\n@@ -108,4 +108,23 @@\n />\n \n \n+ \n+\n+ \n+ \n+ \n+\n \n'