records: added external doi support #20
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alejandromumo
commented
Mar 29, 2023
src/lycophron/tasks/tasks.py
Outdated
| if doi: | ||
| metadata["doi"] = doi | ||
|
|
||
| # TODO implement a serializer to Zenodo |
There was a problem hiding this comment.
This should be a serializer to Zenodo .
alejandromumo
commented
Mar 29, 2023
src/lycophron/tasks/tasks.py
Outdated
| # db.update_record_status(doi, "DEPOSIT_CREATED") | ||
|
|
||
| # TODO uncomment when MemoryError is fixed | ||
| # db.update_record_status(record_id, "DEPOSIT_CREATED") |
There was a problem hiding this comment.
Interacting with the DB inside a celery task raises a MemoryError. This is important because there's no "status" for each record right now. We're blindly uploading the records.
This is bad because e.g. some records might already been uploaded and we do not want to upload them again.
There was a problem hiding this comment.
Opened an issue (#21)
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes #19