Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Play 2.7 support #16

Open
riomus opened this issue Feb 12, 2019 · 5 comments · May be fixed by #89
Open

Play 2.7 support #16

riomus opened this issue Feb 12, 2019 · 5 comments · May be fixed by #89

Comments

@riomus
Copy link

riomus commented Feb 12, 2019

Is this project still supported? Plugins are quite old, Play 2.7 is also a must have, because of WebSocket issues fixed in that version.

We have created a fork where we have a branch with updated plugins, updated SBT, support for Play 2.7 (binary incompatibility with 2.6), I can create a pull request with those changes. Probably we should add support for both play version at once, creating appropriate builds and appending play version to package version.

Currently, it can be used using Jitpack https://jitpack.io/#iambotHQ/play-socket.io (use feature-play27 branch)

@octonato
Copy link
Contributor

Hi @riomus, this project was an experiment @jroper did. The README file states:

The Play backed socket.io support library is Incubating.

However, any PR and improvements are welcome. If the community sees value in it and push it forward, then it gets out of "incubating" stage.

@jroper
Copy link
Member

jroper commented Feb 12, 2019

@renatocaval is right, furthermore, it's not likely that this will ever be an officially supported by Lightbend project. But that doesn't mean that it won't be maintained, as long as people find it useful, people are likely to submit fixes etc. We use it ourselves at Lightbend, so we'll be maintaining it as the need arises for ourselves. Upgrading to Play 2.7 is certainly a good thing, so a PR that provides Play 2.7 support will certainly be welcomed. I don't think cross building against Play 2.6 and 2.7 is a big need, I don't anticipate that there'll be any changes to the API that would warrant maintaining them both together in the same branch, rather, we can bump the version to 2.x, that branch will be built against Play 2.7, and maintain a 1.x branch for Play 2.6, so bug fixes can still be backported if necessary.

@riomus
Copy link
Author

riomus commented Feb 13, 2019

@jroper what do you think about supporting multiple play versions in the same way as in reactivemongo? Cross building with separate source roots for implementations that must differ? I think that in this way it would be more nice and easy to maintain

@jroper
Copy link
Member

jroper commented Feb 13, 2019

That's only worth it if we expect to make changes that we'll want applied to both versions. There is no development planned for play-socket.io, so no changes expected, so setting up cross building is not going to have any value.

@octonato
Copy link
Contributor

octonato commented Feb 14, 2019

@riomus, I would like to add one more thing on top of what @jroper said.

Considering that this project gets some traction, it will be community driven. As such, it's important to keep it small and minimize any friction. If we have built for Play 2.6.x and 2.7.x, it means more work, more maintenance and increases the risk that one, probably 2.6.x, start to lag behind.

I would recommend to start small. Bring in the changes you need and let it grow organically. If there is a real need to evolving a 2.6.x branch, then someone in the community will do it. Chances are that people will prefer to move to 2.7.x instead of maintaining an open source project themselves.

Don't put too much on your plate, because community driven projects are done in our free time and everybody lacks free time. It's the most scarce resources on the planet.

My 2cc.

@ihostage ihostage linked a pull request May 20, 2022 that will close this issue
@ihostage ihostage linked a pull request May 20, 2022 that will close this issue
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants