From fdfad95e7ddcf751e6817404199307aac80336d9 Mon Sep 17 00:00:00 2001
From: Dan0sz <18595395+Dan0sz@users.noreply.github.com>
Date: Wed, 1 May 2024 10:41:01 +0200
Subject: [PATCH] Proper fix for is_list logic.

---
 src/Admin/Settings/API.php | 29 ++++++++++++++---------------
 1 file changed, 14 insertions(+), 15 deletions(-)

diff --git a/src/Admin/Settings/API.php b/src/Admin/Settings/API.php
index 9f7eb4c4..dffd528d 100644
--- a/src/Admin/Settings/API.php
+++ b/src/Admin/Settings/API.php
@@ -10,6 +10,7 @@
 
 namespace Plausible\Analytics\WP\Admin\Settings;
 
+use Plausible\Analytics\WP\Ajax;
 use Plausible\Analytics\WP\Helpers;
 
 /**
@@ -581,23 +582,21 @@ public function render_group_field( array $group, $hide_header = false ) {
 				</header>
 			<?php endif; ?>
 			<?php if ( ! empty( $fields ) ): ?>
-				<?php $is_list = count( $fields ) > 1; ?>
-				<?php if ( $is_list ) {
-					foreach ( $fields as $field ) {
-						if ( $field[ 'type' ] === 'hook' ) {
-							continue;
-						}
-
-						if ( $field[ 'type' ] !== 'checkbox' ) {
-							$is_list = false;
-
-							break;
-						}
+				<?php
+				/**
+				 * if $fields contains more than one checkbox field type, this is a list, which is treated different in @see Ajax::toggle_option()
+				 */
+				$is_list = array_filter(
+					$fields,
+					function ( $field ) {
+						return $field[ 'type' ] === 'checkbox';
 					}
+				);
+
+				foreach ( $fields as $field ) {
+					echo call_user_func( [ $this, "render_{$field['type']}_field" ], $field, count( $is_list ) > 1 );
 				}
-				foreach ( $fields as $field ): ?>
-					<?php echo call_user_func( [ $this, "render_{$field['type']}_field" ], $field, $is_list ); ?>
-				<?php endforeach; ?>
+				?>
 			<?php endif; ?>
 		</div>
 		<?php