Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

updates failing due to update in strapi/strapi #206

Closed
gilzow opened this issue Nov 3, 2023 · 0 comments · Fixed by #207
Closed

updates failing due to update in strapi/strapi #206

gilzow opened this issue Nov 3, 2023 · 0 comments · Fixed by #207
Assignees
Labels
bug Something isn't working

Comments

@gilzow
Copy link
Contributor

gilzow commented Nov 3, 2023

Describe the bug

@strapi/admin at v4.15.1 introduced a warning about needing new dependencies and then prompts the user if they want to install them. 🤦

❯ yarn build
yarn run v1.22.19
$ strapi build
[INFO] The Strapi admin needs to install the following dependencies: 
   - react@^18.0.0
  - react-dom@^18.0.0
  - react-router-dom@^5.0.0
  - styled-components@^5.0.0
? Would you like to install these dependencies now? These are not required but are recommended, from V5 these will be required. (Y/n)

This halts the build process while waiting for interaction, which then timeouts out in the build system, causing the whole build to fail.

Strapi/admin should only produce this prompt if NODE_ENV is set to development. HOWEVER, the default for NODE_ENV if not explicitly set is default. 🤦 X 2.

Easiest solution for now is to explicitly set NODE_ENV to production.

Include some logs

    yarn run v1.22.5
    $ strapi build
    [INFO] The Strapi admin needs to install the following dependencies: 
       - react@^18.0.0
      - react-dom@^18.0.0
      - react-router-dom@^5.0.0
      - styled-components@^5.0.0
    ? Would you like to install these dependencies now? These are not required but 
    W: error Command failed with exit code 130.
    are recommended, from V5 these will be required. (Y/n) info Visit https://yarnpkg.com/en/docs/cli/run for documentation about this command.
  
  E: Error building project: Step failed with status code 130.

E: Error: Unable to build application, aborting.

Reproducing

  1. Update strapi/strapi to 4.15.1
  2. commit yarn.lock
  3. run yarn build

Expected behavior

Should be listed as a warning in stdout

Your environment

n/a

Screenshots

No response

Additional context

No response

@gilzow gilzow added the bug Something isn't working label Nov 3, 2023
@gilzow gilzow self-assigned this Nov 3, 2023
gilzow added a commit that referenced this issue Nov 3, 2023
removes NODE_ENV from start command since it's available now in the system
closes #206
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant