Skip to content
This repository has been archived by the owner on Mar 6, 2023. It is now read-only.

make sure to delete pull-secret.txt from downloads once tearing down the environment #6

Open
yerdreic opened this issue Jan 4, 2023 · 4 comments
Assignees

Comments

@yerdreic
Copy link
Contributor

yerdreic commented Jan 4, 2023

No description provided.

@yerdreic yerdreic self-assigned this Jan 4, 2023
@yerdreic
Copy link
Contributor Author

yerdreic commented Jan 4, 2023

check if we don't need to pull new pull-secret.txt file everytime we run make up

@lmilbaum
Copy link
Contributor

lmilbaum commented Jan 5, 2023

check if we don't need to pull new pull-secret.txt file everytime we run make up

I would suggest to treat pull-secret.txt as a secret file. Store it in a secrets store and consume it dynamically.

@yerdreic
Copy link
Contributor Author

yerdreic commented Jan 5, 2023

@lmilbaum oh I see I added a comment instead of changing the issue's name.
The issue refers to if this pull-secret.txt file is constant - meaning, we can pull is once, then use it all the time - Or, is this file change, so we need to update it - meaning, we need to pull it again from time to time.

I think I will first try to find out what is the purpose of this file in order to answer it

@lmilbaum
Copy link
Contributor

lmilbaum commented Jan 5, 2023

@lmilbaum oh I see I added a comment instead of changing the issue's name. The issue refers to if this pull-secret.txt file is constant - meaning, we can pull is once, then use it all the time - Or, is this file change, so we need to update it - meaning, we need to pull it again from time to time.

I think I will first try to find out what is the purpose of this file in order to answer it

Yup. Makes sense. I think I know the answer but I am not 100% sure. The CRC folks and Tulle can provide the answer.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants