Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Switch to NCC based build #25

Open
sheck opened this issue Oct 10, 2022 · 0 comments
Open

Switch to NCC based build #25

sheck opened this issue Oct 10, 2022 · 0 comments
Labels
enhancement New feature or request

Comments

@sheck
Copy link
Member

sheck commented Oct 10, 2022

In planningcenter/balto-eslint#18 we switched from tracking node_modules to an ncc based build. I attempted to do the same for this repo this morning but ran into a blocking issue.

The static asset relocator webpack plugin that ncc uses copies create_minimal_gemfile.rb and action.rb into the dist folder. It is missing the rest of the ruby files. Ideally, we don't want to copy the files in the first place.

There currently does not seem to be a way to configure this (ncc lists zero configuration on their readme as a design goal) without manually invoking ncc via node (which does not feel like a great solution at the moment).

If NCC changes (or the static relocator plugin does) or if another way to configure the plugin becomes available, we should look into this again.

@sheck sheck added the enhancement New feature or request label Oct 10, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

1 participant