Fix galleries expand past the width of the screen when the links are many #1691
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
👀 |
There was a problem hiding this comment.
This is much better already than the overflowing galleries we have in the app today. I'm impressed -- I think this would've taken me a while to figure out. In addition to my suggestion inline, I think it would be really nice, if possible, to have the dots move and animate each time, like the iOS lock screen switcher. We can talk more about that -- it's hard to describe in a comment here.
|
👀 |
# Conflicts: # CHANGELOG.md
There was a problem hiding this comment.
This and the other files below were duplicates. 🙀
joshuatbrown
added a commit
that referenced
this pull request
Nov 27, 2024
oops! I broke the size in #1691
|
You did a lot of work @joshuatbrown! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issues covered
#24
Description
This pull request fixes an issue where galleries overflow the screen when there are many links. It updates the layout of the gallery dot indicator to ensure the dots stay within note card's bounds.
How to test
Screenshots/Video
Before:
After:
Screen.Recording.2024-11-15.at.5.11.38.PM.mov