Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Buttons inside sheets change to red after swiping through, but not tapping to #1064

Closed
martindsq opened this issue Apr 19, 2024 · 3 comments
Closed
Assignees
Labels
bug Something isn't working

Comments

@martindsq
Copy link
Member

Describe the bug
A clear and concise description of what the bug is.

To Reproduce
Steps to reproduce the behavior:

  1. Go to Profile
  2. Tap on the three dots
  3. Swipe through the options without tapping them, either in the simulator or an actual device
  4. See all options turned permanently to red

Expected behavior
The buttons should return to their former colors.

Screenshots or Video
https://github.com/planetary-social/nos/assets/1703242/c5a51d9d-4435-4c9c-b038-c953d5cb51d9

Technical info (please complete the following information):

  • OS: iOS
  • App Version: 0.1.11
  • Environment: All of them

Additional context
We initially thought it was due to a destructive action we had in one sheet, but it happens in all of them. I don't think it is a destructive red, but it seems to me that the "active" or "selected" state of the buttons are set somewhere or are buggy in swiftui. We could create a new project and find out. Also, the dark mode could be interacting with that.

@bryanmontz
Copy link
Contributor

This issue reproduces on iOS 17.5 and 18.0 simulators.

I tried a small test project and the issue did NOT reproduce there.

@bryanmontz bryanmontz moved this from Backlog to Code Review in Nos Product Board Aug 9, 2024
@bryanmontz
Copy link
Contributor

Here is a relevant page from the Apple Developer Forums:
https://forums.developer.apple.com/forums/thread/673147

github-merge-queue bot pushed a commit that referenced this issue Aug 12, 2024
fix: confirmationDialog buttons turn red while you swipe #1064
@joshuatbrown joshuatbrown moved this from Code Review to UAT in Nos Product Board Aug 12, 2024
@setch-l setch-l closed this as completed Aug 14, 2024
@github-project-automation github-project-automation bot moved this from QA to Done in Nos Product Board Aug 14, 2024
joshuatbrown added a commit that referenced this issue Aug 16, 2024
fix: confirmationDialog buttons turn red while you swipe #1064
@joshuatbrown
Copy link
Contributor

@setch-l Reopening and putting into QA since this will be in the 0.1.25 build.

@joshuatbrown joshuatbrown reopened this Aug 16, 2024
@joshuatbrown joshuatbrown moved this from Done to QA in Nos Product Board Aug 16, 2024
@setch-l setch-l closed this as completed Sep 17, 2024
@github-project-automation github-project-automation bot moved this from QA to Done in Nos Product Board Sep 17, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
Archived in project
Development

No branches or pull requests

4 participants