From e79becfbf79f6b83e84c1e30f81870680cbf1b9a Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Karol=20Bary=C5=82a?= Date: Thu, 1 Aug 2024 10:26:00 +0200 Subject: [PATCH] semver_checks: Revert previous workaround The change in semver-checks was intentional and `cargo install cargo-semver-checks --no-default-features` is no longer expected to work. The replacement command is `cargo install cargo-semver-checks --no-default-features --features gix-reqwest`. See the release notes for v0.33.0: https://github.com/obi1kenobi/cargo-semver-checks/releases/tag/v0.33.0 --- .github/workflows/semver_checks.yml | 28 ++-------------------------- 1 file changed, 2 insertions(+), 26 deletions(-) diff --git a/.github/workflows/semver_checks.yml b/.github/workflows/semver_checks.yml index 6b3067d968..bcad2f0b3c 100644 --- a/.github/workflows/semver_checks.yml +++ b/.github/workflows/semver_checks.yml @@ -61,20 +61,7 @@ jobs: - name: Install semver-checks # Official action uses binary releases fetched from GitHub # If this pipeline becomes too slow, we should do this too. - # - # This works around the Semver violation in tame-index 0.12.2 that renders - # cargo-semver-checks incompilable. Once it gets fixed, revert back - # to using the newest release without customisations. - run: | - pushd .. - git clone https://github.com/obi1kenobi/cargo-semver-checks.git - cd cargo-semver-checks - git checkout v0.32.0 - sed -i '0,/tame-index = { version = "0.12"/s//tame-index = { version = "=0.12.1"/' Cargo.toml - cargo build -r - cargo install --no-default-features --path . - popd - + run: cargo install cargo-semver-checks --no-default-features --features gix-reqwest - name: Verify the API compatibilty with PR base id: semver-pr-check run: | @@ -160,17 +147,6 @@ jobs: - name: Update rust toolchain run: rustup update - name: Install semver-checks - # This works around the Semver violation in tame-index 0.12.2 that renders - # cargo-semver-checks incompilable. Once it gets fixed, revert back - # to using the newest release without customisations. - run: | - pushd .. - git clone https://github.com/obi1kenobi/cargo-semver-checks.git - cd cargo-semver-checks - git checkout v0.32.0 - sed -i '0,/tame-index = { version = "0.12"/s//tame-index = { version = "=0.12.1"/' Cargo.toml - cargo build -r - cargo install --no-default-features --path . - popd + run: cargo install cargo-semver-checks --no-default-features --features gix-reqwest - name: Run semver-checks to see if it agrees with version updates run: make semver-version