Skip to content

Commit

Permalink
ignorableRecords might throw and error when the parameters are JSON s…
Browse files Browse the repository at this point in the history
…erialized #525
  • Loading branch information
pkiraly committed Oct 12, 2024
1 parent 164fa38 commit f4492fc
Show file tree
Hide file tree
Showing 3 changed files with 1 addition and 3 deletions.
Original file line number Diff line number Diff line change
Expand Up @@ -151,7 +151,7 @@ public void alephseq() throws IOException {
@Test
public void marcxml() throws IOException {
clearOutput(outputDir, outputFiles);
inputFile = TestUtils.getPath("marcxml/marcxml.xml")
inputFile = TestUtils.getPath("marcxml/marcxml.xml");

var args = new String[]{
"--defaultRecordType", "BOOKS",
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -321,7 +321,6 @@ public void completeness_pica_groupBy_file() throws Exception {
assertTrue(line.contains("\"trimId\":false,"));
assertTrue(line.contains("\"outputDir\":\"/"));
assertTrue(line.contains("/qa-catalogue/src/test/resources/output\","));
assertTrue(line.contains("\"recordIgnorator\":{\"criteria\":[],\"booleanCriteria\":null,\"empty\":true},"));
assertTrue(line.contains("\"recordFilter\":{\"criteria\":[],\"booleanCriteria\":null,\"empty\":true},"));
assertTrue(line.contains("\"ignorableFields\":{\"fields\":null,\"empty\":true},"));
assertTrue(line.contains("\"stream\":null,"));
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -227,7 +227,6 @@ public void validate_pica_groupBy() throws Exception {
assertTrue(line.contains("\"trimId\":true,"));
assertTrue(line.contains("\"outputDir\":\""));
assertTrue(line.contains("qa-catalogue/src/test/resources/output\","));
assertTrue(line.contains("\"recordIgnorator\":{\"criteria\":[],\"booleanCriteria\":null,\"empty\":true},"));
assertTrue(line.contains("\"recordFilter\":{\"criteria\":[],\"booleanCriteria\":null,\"empty\":true},"));
assertTrue(line.contains("\"ignorableFields\":{\"fields\":null,\"empty\":true},"));
assertTrue(line.contains("\"stream\":null,"));
Expand Down

0 comments on commit f4492fc

Please sign in to comment.