Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature request: Ability to use DNS names in service connection details #74

Open
jimconner opened this issue Feb 2, 2021 · 1 comment

Comments

@jimconner
Copy link

The shared-redis broker issues connection details which use the IP address of the redis-broker VM.

VCAP_SERVICES: {
 "p-redis": [
  {
   "binding_name": null,
   "credentials": {
    "host": "192.168.0.10",
    "password": "some-long-uuid-style-password",
    "port": 37715
   },
   "instance_name": "my-redis-service",
   "label": "p-redis",
   "name": "my-redis-service",
   "plan": "shared-vm",

We've been doing daily backups our redis deployments for a long time. We recently performed a 'restore test' to validate that we'd been backing up everything correctly and discovered that we have an issue around redis service. During the test we did 'bosh delete-deployment cf-redis', then redeployed it and restored the data. When BOSH deployed the new VM it did not have the same IP address as the destroyed one. Therefore, even after restoring all of the data redis clients were unable to connect as their service_instances all referenced the old IP address from the deleted deployment.

A simple solution would be to use a DNS name instead of IP address when issuing the service credentials. Setting up a suitable DNS name in bosh-dns is trivial, but it appears that currently there isn't the ability to pass a manifest property for the hostname into the job.

In jobs/cf-redis-broker/templates/broker.yml.erb we can see that the 'host' parameter is using spec.ip

redis:
  service_name: <%= p('redis.broker.service_name') %>
  service_id: <%= p('redis.broker.service_id') %>
  shared_vm_plan_id: <%= p('redis.broker.shared_vm_plan_id') %>
  host: <%= spec.ip %>

I'd like to request the ability to use a DNS name as an alternative to the current 'spec.ip' - This will make backup/restore operations simpler.

@cf-gitbot
Copy link
Member

We have created an issue in Pivotal Tracker to manage this. Unfortunately, the Pivotal Tracker project is private so you may be unable to view the contents of the story.

The labels on this github issue will be updated when the story is started.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants