Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

use "name" field from the product template as the default file name instead of "tile" #437

Open
crhntr opened this issue Sep 5, 2023 · 1 comment

Comments

@crhntr
Copy link
Contributor

crhntr commented Sep 5, 2023

Is your feature request related to a problem? Please describe.

I have been reading tile build scripts and found most scripts do this kind of thing.

We should have a better default than tile-"${TILE_VERSION}.pivotal. I found that this team could reduce the code after kiln bake in their script if we do something similar to what they are doing.

https://github.com/pivotal/cryogenics-concourse-tasks/blob/a4109ac940e5adf5cfa7d4f806c915b3393bd215/tasks/kiln-bake-task/task.sh

Another option would be to have configuration in the Kilnfile for this. Preferably the Kilnfile would allow multiple configurations so it would work for tas-releng too.

Describe the solution you'd like

I'd like to see the build file name to be configurable in the Kilnfile.
If the configuration does not exist, fall back to tile-"${TILE_VERSION}.pivotal.

Describe alternatives you've considered

No response

Additional context

This would require changes to the kiln-buildpack and the concourse resource to fetch tiles out of harbor.

@cf-gitbot
Copy link
Member

We have created an issue in Pivotal Tracker to manage this. Unfortunately, the Pivotal Tracker project is private so you may be unable to view the contents of the story.

The labels on this github issue will be updated when the story is started.

crhntr added a commit that referenced this issue Jul 24, 2024
crhntr added a commit that referenced this issue Jul 24, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants