-
-
Notifications
You must be signed in to change notification settings - Fork 380
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
WIP warning redux #5260
base: master
Are you sure you want to change the base?
WIP warning redux #5260
Conversation
insane clang
d1574f9
to
7d2597d
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
In all cases, please do not use bitwise-and with a literal constant, instead please prefer uint32_t(<expr>)
(or as needed) as a functional-style cast instead.
Ive been debating with myself which one makes more sense. The resulting code should be identical but the anding version makes more explicit that bit are truncated, a simple typecast looks neater but later on it may be overlooked that it actually truncates bits. |
The lack of visual clarity far outweighs any semantic benefit that might be gained by highlighting the fact that we're truncating the array size to only four billion entries. Please use the functional-style cast, explicit bit constants add visual clutter and make the code harder to read for no benefit in this case. |
bop
8c7760a
to
93db152
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I appreciate the effort in fixing all of these warning locations - there are a few tweaks related to the preprocessor that I'd like to see made, but once those are done I'm happy to merge this (with the debug messages removed, of course).
876b6fc
to
b5bc47c
Compare
90e4530
to
6a3a044
Compare
try to reduce warning spam during compilation
"WIP": while pragma messages are in place to see where warning have been fixed
if PR is accepted the final step would be to clean out all pragma messages