Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[MISC] Use <stdbool.h> for bool type #198

Open
levincent06 opened this issue Mar 23, 2021 · 0 comments
Open

[MISC] Use <stdbool.h> for bool type #198

levincent06 opened this issue Mar 23, 2021 · 0 comments
Labels
code-cleanup Code health fixes/improvements good-first-issue Good issues for incoming members
Milestone

Comments

@levincent06
Copy link
Member

Among other ways to implement the bool type in C (ex: typedef, #define, more here: https://stackoverflow.com/a/1921557), using stdbool.h seems be the safest option.

We should start using this bool type across the Runtime repo and use it where applicable in the current code. An exception to using stdbool.h is for boolean values that are size-sensitive. For example, the param_val_t union should still use uint8_t for boolean values because we encode/decode booleans as 1-byte values in the lowcar protocol.

@levincent06 levincent06 added the code-cleanup Code health fixes/improvements label Mar 23, 2021
@benliao1 benliao1 added this to the 1.2 milestone Mar 24, 2021
@benliao1 benliao1 added the good-first-issue Good issues for incoming members label Sep 22, 2021
@zengstellas zengstellas self-assigned this Feb 10, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
code-cleanup Code health fixes/improvements good-first-issue Good issues for incoming members
Projects
None yet
Development

No branches or pull requests

4 participants