Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add NADA implementation #117

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Add NADA implementation #117

wants to merge 1 commit into from

Conversation

kevmo314
Copy link

@kevmo314 kevmo314 commented Apr 2, 2022

This change adds the NADA congestion control implementation.
The binding to cc is left TODO.

@codecov
Copy link

codecov bot commented Apr 2, 2022

Codecov Report

Merging #117 (48779ed) into master (09051cd) will decrease coverage by 0.01%.
The diff coverage is 79.16%.

@@            Coverage Diff             @@
##           master     #117      +/-   ##
==========================================
- Coverage   79.30%   79.29%   -0.02%     
==========================================
  Files          51       56       +5     
  Lines        2460     2748     +288     
==========================================
+ Hits         1951     2179     +228     
- Misses        419      470      +51     
- Partials       90       99       +9     
Flag Coverage Δ
go 79.29% <79.16%> (-0.02%) ⬇️
wasm ?

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
interceptor.go 100.00% <ø> (ø)
pkg/nack/retainable_packet.go 86.76% <ø> (ø)
pkg/nada/report.go 0.00% <0.00%> (ø)
pkg/nada/packet_stream.go 65.75% <65.75%> (ø)
pkg/nada/receiver.go 93.67% <93.67%> (ø)
pkg/nada/sender.go 93.75% <93.75%> (ø)
pkg/nada/config.go 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 09051cd...48779ed. Read the comment docs.

This change adds the NADA congestion control implementation.
The binding to cc is left TODO.
@mengelbart
Copy link
Contributor

@kevmo314 This is great, thanks for implementing it! Sorry I didn't get to review/test this earlier! I started #149 now to integrate it into interceptors and will try to find some time to review the code and understand NADA better.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

2 participants