Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove the "event feed starts to check locked regions" log 🔥🔥🔥 #11948

Open
kennytm opened this issue Dec 30, 2024 · 1 comment
Open
Labels
affects-6.5 This bug affects the 6.5.x(LTS) versions. affects-7.1 This bug affects the 7.1.x(LTS) versions. affects-7.5 This bug affects the 7.5.x(LTS) versions. affects-8.1 This bug affects the 8.1.x(LTS) versions. affects-8.5 This bug affects the 8.5.x(LTS) versions. area/ticdc Issues or PRs related to TiCDC. type/enhancement The issue or PR belongs to an enhancement.

Comments

@kennytm
Copy link
Contributor

kennytm commented Dec 30, 2024

Is your feature request related to a problem?

The CDC log is full of these useless entries. It makes the CDC log very large, and thus the log file very slow to open for reading, and very annoying to locate any actual problem.

$ wc -l cdc-1.log
  247586 cdc-1.log
$ rg -c 'event feed starts to check locked regions' cdc-1.log
242538
$ echo $(( 242538.0 / 247586 ))
0.97961112502322423
Image

Describe the feature you'd like

Reduce the log level to DEBUG or just nuke it from orbit.

log.Info("event feed starts to check locked regions",
zap.String("namespace", s.changefeed.Namespace),
zap.String("changefeed", s.changefeed.ID))

Describe alternatives you've considered

No response

Teachability, Documentation, Adoption, Migration Strategy

No response

@kennytm kennytm added affects-6.5 This bug affects the 6.5.x(LTS) versions. affects-7.1 This bug affects the 7.1.x(LTS) versions. affects-7.5 This bug affects the 7.5.x(LTS) versions. affects-8.1 This bug affects the 8.1.x(LTS) versions. affects-8.5 This bug affects the 8.5.x(LTS) versions. area/ticdc Issues or PRs related to TiCDC. type/feature Issues about a new feature type/enhancement The issue or PR belongs to an enhancement. and removed type/feature Issues about a new feature labels Dec 30, 2024
@lance6716
Copy link
Contributor

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
affects-6.5 This bug affects the 6.5.x(LTS) versions. affects-7.1 This bug affects the 7.1.x(LTS) versions. affects-7.5 This bug affects the 7.5.x(LTS) versions. affects-8.1 This bug affects the 8.1.x(LTS) versions. affects-8.5 This bug affects the 8.5.x(LTS) versions. area/ticdc Issues or PRs related to TiCDC. type/enhancement The issue or PR belongs to an enhancement.
Projects
None yet
Development

No branches or pull requests

2 participants