-
Notifications
You must be signed in to change notification settings - Fork 687
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
tidb: make Foreign Key GA #19003
tidb: make Foreign Key GA #19003
Conversation
Signed-off-by: Yang Keao <[email protected]>
b95a79b
to
ce468a3
Compare
Co-authored-by: xixirangrang <[email protected]>
/hold It has been postponed to v8.5 |
7f5ec25
to
dff7101
Compare
Signed-off-by: Yang Keao <[email protected]>
dff7101
to
4f71e16
Compare
/unhold |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I made more updates to relevant docs and adjust some wording via 986491d. PTAL, thanks!
[LGTM Timeline notifier]Timeline:
|
Co-authored-by: xixirangrang <[email protected]>
/lgtm |
/approve |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: lilin90 The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
First-time contributors' checklist
What is changed, added or deleted? (Required)
The foreign key feature is about to GA in v8.4. Let's remove the experiment mark for it in v8.4.
Which TiDB version(s) do your changes apply to? (Required)
Tips for choosing the affected version(s):
By default, CHOOSE MASTER ONLY so your changes will be applied to the next TiDB major or minor releases. If your PR involves a product feature behavior change or a compatibility change, CHOOSE THE AFFECTED RELEASE BRANCH(ES) AND MASTER.
For details, see tips for choosing the affected versions.
What is the related PR or file link(s)?
Do your changes match any of the following descriptions?