Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

tidb: make Foreign Key GA #19003

Merged
merged 5 commits into from
Nov 22, 2024
Merged

Conversation

YangKeao
Copy link
Member

@YangKeao YangKeao commented Sep 24, 2024

First-time contributors' checklist

What is changed, added or deleted? (Required)

The foreign key feature is about to GA in v8.4. Let's remove the experiment mark for it in v8.4.

Which TiDB version(s) do your changes apply to? (Required)

Tips for choosing the affected version(s):

By default, CHOOSE MASTER ONLY so your changes will be applied to the next TiDB major or minor releases. If your PR involves a product feature behavior change or a compatibility change, CHOOSE THE AFFECTED RELEASE BRANCH(ES) AND MASTER.

For details, see tips for choosing the affected versions.

  • master (the latest development version)
  • v8.5 (TiDB 8.5 versions)
  • v8.4 (TiDB 8.4 versions)
  • v8.3 (TiDB 8.3 versions)
  • v8.2 (TiDB 8.2 versions)
  • v8.1 (TiDB 8.1 versions)
  • v7.5 (TiDB 7.5 versions)
  • v7.1 (TiDB 7.1 versions)
  • v6.5 (TiDB 6.5 versions)
  • v6.1 (TiDB 6.1 versions)
  • v5.4 (TiDB 5.4 versions)
  • v5.3 (TiDB 5.3 versions)

What is the related PR or file link(s)?

Do your changes match any of the following descriptions?

  • Delete files
  • Change aliases
  • Need modification after applied to another branch
  • Might cause conflicts after applied to another branch

@ti-chi-bot ti-chi-bot bot added missing-translation-status This PR does not have translation status info. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Sep 24, 2024
@YangKeao YangKeao force-pushed the remove-fk-experiment branch from b95a79b to ce468a3 Compare September 24, 2024 11:55
@Oreoxmt Oreoxmt added do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. v8.4 This PR/issue applies to TiDB v8.4. labels Sep 25, 2024
@lilin90 lilin90 added the translation/from-docs-cn This PR is translated from a PR in pingcap/docs-cn. label Sep 25, 2024
@ti-chi-bot ti-chi-bot bot removed the missing-translation-status This PR does not have translation status info. label Sep 25, 2024
@lilin90 lilin90 requested review from lilin90 and hfxsd September 25, 2024 06:24
foreign-key.md Outdated Show resolved Hide resolved
@ti-chi-bot ti-chi-bot bot added the needs-1-more-lgtm Indicates a PR needs 1 more LGTM. label Sep 26, 2024
@YangKeao
Copy link
Member Author

/hold

It has been postponed to v8.5

@YangKeao YangKeao removed the v8.4 This PR/issue applies to TiDB v8.4. label Sep 26, 2024
@lilin90 lilin90 added the v8.5 label Oct 30, 2024
@YangKeao YangKeao force-pushed the remove-fk-experiment branch from 7f5ec25 to dff7101 Compare October 31, 2024 04:25
@YangKeao YangKeao force-pushed the remove-fk-experiment branch from dff7101 to 4f71e16 Compare October 31, 2024 04:27
@YangKeao
Copy link
Member Author

/unhold

@ti-chi-bot ti-chi-bot bot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Nov 18, 2024
@ti-chi-bot ti-chi-bot bot added area/develop This PR relates to the area of TiDB App development. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. and removed size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Nov 19, 2024
@lilin90 lilin90 requested a review from crazycs520 November 19, 2024 03:42
Copy link
Member

@lilin90 lilin90 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I made more updates to relevant docs and adjust some wording via 986491d. PTAL, thanks!

@ti-chi-bot ti-chi-bot bot added lgtm and removed needs-1-more-lgtm Indicates a PR needs 1 more LGTM. labels Nov 19, 2024
Copy link

ti-chi-bot bot commented Nov 19, 2024

[LGTM Timeline notifier]

Timeline:

  • 2024-09-26 01:42:21.675414861 +0000 UTC m=+1703011.415838799: ☑️ agreed by hfxsd.
  • 2024-11-19 03:55:59.158178732 +0000 UTC m=+933321.349047933: ☑️ agreed by crazycs520.

@lilin90
Copy link
Member

lilin90 commented Nov 22, 2024

/lgtm

@lilin90
Copy link
Member

lilin90 commented Nov 22, 2024

/approve

Copy link

ti-chi-bot bot commented Nov 22, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: lilin90

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ti-chi-bot ti-chi-bot bot added the approved label Nov 22, 2024
@ti-chi-bot ti-chi-bot bot merged commit 31d5e38 into pingcap:master Nov 22, 2024
8 of 9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved area/develop This PR relates to the area of TiDB App development. lgtm size/S Denotes a PR that changes 10-29 lines, ignoring generated files. translation/from-docs-cn This PR is translated from a PR in pingcap/docs-cn. v8.5
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants