Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

flashback: add limitation with stale read/snapshot #18903

Merged
merged 5 commits into from
Dec 16, 2024
Merged

flashback: add limitation with stale read/snapshot #18903

merged 5 commits into from
Dec 16, 2024

Conversation

3pointer
Copy link
Contributor

First-time contributors' checklist

What is changed, added or deleted? (Required)

Which TiDB version(s) do your changes apply to? (Required)

Tips for choosing the affected version(s):

By default, CHOOSE MASTER ONLY so your changes will be applied to the next TiDB major or minor releases. If your PR involves a product feature behavior change or a compatibility change, CHOOSE THE AFFECTED RELEASE BRANCH(ES) AND MASTER.

For details, see tips for choosing the affected versions (in Chinese).

  • master (the latest development version)
  • v8.4 (TiDB 8.4 versions)
  • v8.3 (TiDB 8.3 versions)
  • v8.2 (TiDB 8.2 versions)
  • v8.1 (TiDB 8.1 versions)
  • v7.5 (TiDB 7.5 versions)
  • v7.1 (TiDB 7.1 versions)
  • v6.5 (TiDB 6.5 versions)
  • v6.1 (TiDB 6.1 versions)
  • v5.4 (TiDB 5.4 versions)
  • v5.3 (TiDB 5.3 versions)

What is the related PR or file link(s)?

  • This PR is translated from:
  • Other reference link(s):

Do your changes match any of the following descriptions?

  • Delete files
  • Change aliases
  • Need modification after applied to another branch
  • Might cause conflicts after applied to another branch

@ti-chi-bot ti-chi-bot bot added missing-translation-status This PR does not have translation status info. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Oct 25, 2024
@ti-chi-bot ti-chi-bot
Copy link

ti-chi-bot bot commented Oct 25, 2024

@YuJuncen: adding LGTM is restricted to approvers and reviewers in OWNERS files.

In response to this:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@ti-chi-bot ti-chi-bot
Copy link

ti-chi-bot bot commented Oct 25, 2024

@BornChanger: adding LGTM is restricted to approvers and reviewers in OWNERS files.

In response to this:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@qiancai qiancai self-assigned this Oct 28, 2024
qiancai
qiancai approved these changes Oct 28, 2024
View reviewed changes
Copy link
Collaborator

@qiancai qiancai left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Rest LGTM

sql-statements/sql-statement-flashback-cluster.md Outdated Show resolved Hide resolved
@ti-chi-bot ti-chi-bot bot added the needs-1-more-lgtm Indicates a PR needs 1 more LGTM. label Oct 28, 2024
@ti-chi-bot ti-chi-bot
Copy link

ti-chi-bot bot commented Oct 28, 2024

[LGTM Timeline notifier]

Timeline:

  • 2024-10-28 08:49:28.540807944 +0000 UTC m=+253281.379963491: ☑️ agreed by qiancai.

@qiancai qiancai added translation/doing This PR’s assignee is translating this PR. needs-cherry-pick-release-7.5 Should cherry pick this PR to release-7.5 branch. needs-cherry-pick-release-8.1 Should cherry pick this PR to release-8.1 branch. needs-cherry-pick-release-8.2 Should cherry pick this PR to release-8.2 branch. needs-cherry-pick-release-8.3 Should cherry pick this PR to release-8.3 branch. needs-cherry-pick-release-8.4 Should cherry pick this PR to release-8.4 branch. and removed missing-translation-status This PR does not have translation status info. labels Oct 28, 2024
@qiancai qiancai mentioned this pull request Nov 6, 2024
Merged
16 tasks
@qiancai qiancai added translation/done This PR has been translated from English into Chinese and updated to pingcap/docs-cn in a PR. and removed translation/doing This PR’s assignee is translating this PR. labels Nov 7, 2024
@qiancai qiancai added the needs-cherry-pick-release-8.5 Should cherry pick this PR to release-8.5 branch. label Dec 3, 2024
@qiancai
Copy link
Collaborator

qiancai commented Dec 16, 2024

/approve

@qiancai qiancai added the lgtm label Dec 16, 2024
@ti-chi-bot ti-chi-bot
Copy link

ti-chi-bot bot commented Dec 16, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: qiancai

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ti-chi-bot ti-chi-bot bot added the approved label Dec 16, 2024
@ti-chi-bot ti-chi-bot bot merged commit 6cb5723 into master Dec 16, 2024
7 checks passed
@ti-chi-bot ti-chi-bot bot deleted the flashback_limitation branch December 16, 2024 03:33
@ti-chi-bot
Copy link
Member

In response to a cherrypick label: new pull request created to branch release-8.3: #19309.

@ti-chi-bot ti-chi-bot mentioned this pull request Dec 16, 2024
Merged
16 tasks
@ti-chi-bot
Copy link
Member

In response to a cherrypick label: new pull request created to branch release-8.5: #19310.

@ti-chi-bot ti-chi-bot mentioned this pull request Dec 16, 2024
Merged
16 tasks
@ti-chi-bot
Copy link
Member

In response to a cherrypick label: new pull request created to branch release-8.4: #19311.

@ti-chi-bot ti-chi-bot mentioned this pull request Dec 16, 2024
Merged
16 tasks
@ti-chi-bot
Copy link
Member

In response to a cherrypick label: new pull request created to branch release-7.5: #19312.

@ti-chi-bot ti-chi-bot mentioned this pull request Dec 16, 2024
Merged
16 tasks
@ti-chi-bot
Copy link
Member

In response to a cherrypick label: new pull request created to branch release-8.1: #19313.

@ti-chi-bot ti-chi-bot mentioned this pull request Dec 16, 2024
Merged
16 tasks
@ti-chi-bot
Copy link
Member

In response to a cherrypick label: new pull request created to branch release-8.2: #19314.

@ti-chi-bot ti-chi-bot mentioned this pull request Dec 16, 2024
Merged
16 tasks
ti-chi-bot bot pushed a commit that referenced this pull request Dec 16, 2024
@ti-chi-bot
flashback: add limitation with stale read/snapshot (#18903) (#19311)
153d7ca
ti-chi-bot bot pushed a commit that referenced this pull request Dec 16, 2024
@ti-chi-bot
flashback: add limitation with stale read/snapshot (#18903) (#19309)
f1b94d3
This was referenced Dec 16, 2024
Merged
Merged
Merged
ti-chi-bot bot pushed a commit that referenced this pull request Dec 16, 2024
@ti-chi-bot
flashback: add limitation with stale read/snapshot (#18903) (#19313)
98e1837
ti-chi-bot bot pushed a commit that referenced this pull request Dec 16, 2024
@ti-chi-bot
flashback: add limitation with stale read/snapshot (#18903) (#19314)
be55136
This was referenced Dec 16, 2024
Merged
Merged
Merged
ti-chi-bot bot pushed a commit that referenced this pull request Dec 16, 2024
@ti-chi-bot
flashback: add limitation with stale read/snapshot (#18903) (#19312)
96e7513
ti-chi-bot bot pushed a commit that referenced this pull request Dec 16, 2024
@ti-chi-bot
flashback: add limitation with stale read/snapshot (#18903) (#19310)
aa473e6
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@qiancai qiancai qiancai approved these changes

@BornChanger BornChanger BornChanger approved these changes

@YuJuncen YuJuncen YuJuncen approved these changes

Assignees

@qiancai qiancai

Labels
approved lgtm needs-1-more-lgtm Indicates a PR needs 1 more LGTM. needs-cherry-pick-release-7.5 Should cherry pick this PR to release-7.5 branch. needs-cherry-pick-release-8.1 Should cherry pick this PR to release-8.1 branch. needs-cherry-pick-release-8.2 Should cherry pick this PR to release-8.2 branch. needs-cherry-pick-release-8.3 Should cherry pick this PR to release-8.3 branch. needs-cherry-pick-release-8.4 Should cherry pick this PR to release-8.4 branch. needs-cherry-pick-release-8.5 Should cherry pick this PR to release-8.5 branch. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. translation/done This PR has been translated from English into Chinese and updated to pingcap/docs-cn in a PR.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@3pointer @qiancai @ti-chi-bot @YuJuncen @BornChanger