Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bug]: Filter might cause Exceptions when they are not set #166

Open
AlternateIf opened this issue Mar 1, 2024 · 1 comment
Open

[Bug]: Filter might cause Exceptions when they are not set #166

AlternateIf opened this issue Mar 1, 2024 · 1 comment

Comments

@AlternateIf
Copy link
Contributor

Expected behavior

When a filter is not set, no condition is added and no exception/warning is produced

Actual behavior

In case of a filter being EMPTY_STRING or unset the current implementation leads to an exception since trim expects its argument to be a string but gets null

See https://github.com/pimcore/ecommerce-framework-bundle/blob/1.x/src/FilterService/FilterType/ElasticSearch/SelectFromMultiSelect.php#L35 for example

Maybe cast it to string like it was done here
https://github.com/pimcore/ecommerce-framework-bundle/blob/1.x/src/FilterService/FilterType/ElasticSearch/Select.php#L44
or do the trim only when it the value is not null like it was done here: https://github.com/pimcore/ecommerce-framework-bundle/blob/1.x/src/FilterService/FilterType/ElasticSearch/SelectCategory.php#L79

This also applies to the non Elastic Search Equivalent of SelectFromMultiSelect and the Input filter

Steps to reproduce

@AlternateIf AlternateIf added the Bug label Mar 1, 2024
Copy link

Thanks a lot for reporting the issue. We did not consider the issue as "Pimcore:Priority", "Pimcore:ToDo" or "Pimcore:Backlog", so we're not going to work on that anytime soon. Please create a pull request to fix the issue if this is a bug report. We'll then review it as quickly as possible. If you're interested in contributing a feature, please contact us first here before creating a pull request. We'll then decide whether we'd accept it or not. Thanks for your understanding.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant