Data Selector for JSON Payload #437
Open
+34
−9
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cancan101
commented
Nov 22, 2024
| @@ -45,6 +45,7 @@ plugin_pimcore_datahub_data_importer_configpanel_csv_escape: Escape | |||
| plugin_pimcore_datahub_data_importer_configpanel_xlsx_sheet: Sheet | |||
| plugin_pimcore_datahub_data_importer_configpanel_xml_xpath: XPath | |||
| plugin_pimcore_datahub_data_importer_configpanel_xml_schema: Schema | |||
| plugin_pimcore_datahub_data_importer_configpanel_json_path: Path | |||
There was a problem hiding this comment.
I have seen the name "path" and "expression" used. do we have a preference?
cancan101
commented
Nov 22, 2024
| xtype: 'textfield', | ||
| fieldLabel: t('plugin_pimcore_datahub_data_importer_configpanel_json_path'), | ||
| name: this.dataNamePrefix + 'path', | ||
| value: this.data.path || '', |
There was a problem hiding this comment.
do I need anything else here, such as:
allowBlank: true,
msgTarget: 'under'
cancan101
commented
Nov 22, 2024
| @@ -32,13 +35,17 @@ class JsonFileInterpreter extends AbstractInterpreter | |||
|
|
|||
| protected function loadData(string $path): array | |||
| { | |||
| if ($this->cachedFilePath === $path && !empty($this->cachedContent)) { | |||
| if ($this->cachedFilePath !== $path || empty($this->cachedContent)) { | |||
There was a problem hiding this comment.
i believe this logic was wrong before. See fix for Xml: #438
|
cancan101
commented
Nov 26, 2024
| @@ -52,7 +63,7 @@ protected function doInterpretFileAndCallProcessRow(string $path): void | |||
|
|
|||
| public function setSettings(array $settings): void | |||
| { | |||
| //nothing to do | |||
| $this->path = $settings['path']; | |||
There was a problem hiding this comment.
do we want to do any validation here that the path passed in is a valid JmesPath?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See: https://github.com/orgs/pimcore/discussions/17670#discussion-7265373
CC @fashxp
This does add a new dep: "mtdowling/jmespath.php" (https://github.com/jmespath/jmespath.php)