Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add ObjectField Operator for extracting fields from Data Objects. #436

Open
wants to merge 2 commits into
base: 1.x
Choose a base branch
from

Conversation

cancan101
Copy link
Contributor

@fashxp
Copy link
Member

fashxp commented Nov 21, 2024

very nice, thx! will check in detail as soon we get some time.

two things I noticed right away:

thx again.

@cancan101
Copy link
Contributor Author

cancan101 commented Nov 21, 2024

in JS we should specific translation keys for the fieldLabel - to be independent and more flexible when choosing more descriptive field labels.

What do you mean here? The translation keys I chose exist and are used by: https://pimcore.com/docs/pimcore/10.1/User_Documentation/DataObjects/Grid_Configuration_Operators/Extractors/AnyGetter.html

forward_parameter and attribute have the same meaning here as they do in the AnyGetter

Copy link

sonarcloud bot commented Nov 26, 2024

Quality Gate Failed Quality Gate failed

Failed conditions
2 New Major Issues (required ≤ 0)

See analysis details on SonarQube Cloud

Catch issues before they fail your Quality Gate with our IDE extension SonarQube for IDE

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants