Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Notification counter does not decrease after notification is read #712

Open
kkowalczuklemon opened this issue Oct 4, 2024 · 1 comment

Comments

@kkowalczuklemon
Copy link

After reading notification from the list of notifications, the notification counter does not decrease its value.

image

The same situation is when, for example, we have 8 notifications, we read 4 of them and during the reading we receive an additional notification. The counter should refresh and display the value of 5 but still displays 8.

This code is responsible for updating the counter:

pimcore.notification.helper.updateCount = function (count) {
var currentValue = Ext.get("notification_value").getHtml();
if(currentValue > count) {
return;
}
if (count > 0) {
Ext.get("notification_value").show();
Ext.fly('notification_value').update(count);
} else {
Ext.get("notification_value").hide();
}
};

The condition on line 22 blocks the possibility of entering a smaller value than the current one.

Copy link

Thanks a lot for reporting the issue. We did not consider the issue as "Pimcore:Priority", "Pimcore:ToDo" or "Pimcore:Backlog", so we're not going to work on that anytime soon. Please create a pull request to fix the issue if this is a bug report. We'll then review it as quickly as possible. If you're interested in contributing a feature, please contact us first here before creating a pull request. We'll then decide whether we'd accept it or not. Thanks for your understanding.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant