Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ready for review #15

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

ready for review #15

wants to merge 2 commits into from

Conversation

mensch72
Copy link
Contributor

as discussed today with @ccatherinetan

@mensch72 mensch72 requested a review from ccatherinetan August 12, 2024 21:26
@mensch72 mensch72 linked an issue Aug 12, 2024 that may be closed by this pull request
@@ -183,6 +187,8 @@ def step():
t += 1
if stepping: stepping = False

agent = None

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this line is repeated on line 120. Do we want to delete it here?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yes, resolved now.

Copy link

@ccatherinetan ccatherinetan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think it looks good! Just 1 comment about agent=None

@mensch72
Copy link
Contributor Author

I think it looks good! Just 1 comment about agent=None

did you test it?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Python: Agent.act()
2 participants