Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

HF - Display VHF alias frequency #199

Open
Adrian2k opened this issue Nov 2, 2024 · 9 comments
Open

HF - Display VHF alias frequency #199

Adrian2k opened this issue Nov 2, 2024 · 9 comments

Comments

@Adrian2k
Copy link

Adrian2k commented Nov 2, 2024

So in AFV you can see what VHF frequency is aliased to your HF frequency - this does not seem to be a feature in trackaudio
image

@Adrian2k
Copy link
Author

Adrian2k commented Nov 2, 2024

Same issue in beta3
image

@GeorgeBarlow
Copy link
Collaborator

GeorgeBarlow commented Nov 2, 2024

This is currently not a supported feature, we'd need to look into expanding our implementation of interfacing with the VATSIM audio network before providing this feature.

@pierr3 this would require some sort of change to APISession on afv-native to access the frequencyAlias key on the incoming json from the AFV api as it currently passes through only a string containing the name of the station and an unsigned int containing the frequency from the frequency element on the json. Probably would be worth while just defining a struct and replacing the int with that when returning the std::pair.

@pierr3
Copy link
Owner

pierr3 commented Nov 2, 2024 via email

@GeorgeBarlow
Copy link
Collaborator

GeorgeBarlow commented Nov 4, 2024

preview

WIP subject to change: showcasing an idea that I've been playing around with. Hover the frequency to find the alias, or click the alias to flip the persisted frequency around (between HF or VHF), marks paired frequencies with the VHF/HF icon in the top left hand corner of the radio box

@neilenns
Copy link
Contributor

neilenns commented Nov 4, 2024

Looks so good 😍

@pierr3
Copy link
Owner

pierr3 commented Nov 4, 2024

Looking great, would suggest it defaults back to HF frequency on leaving the hover zone but otherwise good solution

@GeorgeBarlow
Copy link
Collaborator

Looking great, would suggest it defaults back to HF frequency on leaving the hover zone but otherwise good solution

It does by default show the HF and only on hover the VHF, but the user can click it to switch it around if they desire.

@pierr3
Copy link
Owner

pierr3 commented Nov 13, 2024

@Adrian2k what is your take on the proposed UI fix above? Do you need both frequencies displayed at all times or is the bottom bar extended info sufficient?

@Adrian2k
Copy link
Author

@Adrian2k what is your take on the proposed UI fix above? Do you need both frequencies displayed at all times or is the bottom bar extended info sufficient?

Either one is a good solution in my mind

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants