Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Treat external repositories as system headers for warning purposes. #436

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Treat external repositories as system headers for warning purposes. #436

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 11 additions & 0 deletions .bazelrc
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -12,12 +12,23 @@
# See the License for the specific language governing permissions and
# limitations under the License.

common --enable_platform_specific_config

build --process_headers_in_dependencies

# Run Pylint by default.
build --aspects='//private:defs.bzl%check_python'
build --output_groups='+check_python'

# The external_include_paths feature has to be specified in .bazelrc because it
# needs to apply to all compile actions in all repositories.
# TODO: File bug against Bazel to make this work as repository-level feature.
build --features=external_include_paths --host_features=external_include_paths

# The next line shouldn’t be necessary.
# TODO: File bug against Bazel.
build:windows --copt=/external:W3

import %workspace%/c-std.bazelrc

try-import %workspace%/github.bazelrc
16 changes: 0 additions & 16 deletions elisp/binary.cc
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -16,24 +16,8 @@

#include <initializer_list>

#ifdef __GNUC__
# pragma GCC diagnostic push
# pragma GCC diagnostic ignored "-Wpedantic"
# pragma GCC diagnostic ignored "-Wconversion"
# pragma GCC diagnostic ignored "-Wsign-conversion"
# pragma GCC diagnostic ignored "-Woverflow"
#endif
#ifdef _MSC_VER
# pragma warning(push, 3)
#endif
#include "absl/status/statusor.h"
#include "absl/types/span.h"
#ifdef __GNUC__
# pragma GCC diagnostic pop
#endif
#ifdef _MSC_VER
# pragma warning(pop)
#endif

#include "elisp/platform.h"
#include "elisp/process.h"
Expand Down
16 changes: 0 additions & 16 deletions elisp/binary.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -21,24 +21,8 @@

#include <initializer_list>

#ifdef __GNUC__
# pragma GCC diagnostic push
# pragma GCC diagnostic ignored "-Wpedantic"
# pragma GCC diagnostic ignored "-Wconversion"
# pragma GCC diagnostic ignored "-Wsign-conversion"
# pragma GCC diagnostic ignored "-Woverflow"
#endif
#ifdef _MSC_VER
# pragma warning(push, 3)
#endif
#include "absl/status/statusor.h"
#include "absl/types/span.h"
#ifdef __GNUC__
# pragma GCC diagnostic pop
#endif
#ifdef _MSC_VER
# pragma warning(pop)
#endif

#include "elisp/platform.h"

Expand Down
16 changes: 0 additions & 16 deletions elisp/emacs.cc
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -16,24 +16,8 @@

#include <string_view>

#ifdef __GNUC__
# pragma GCC diagnostic push
# pragma GCC diagnostic ignored "-Wpedantic"
# pragma GCC diagnostic ignored "-Wconversion"
# pragma GCC diagnostic ignored "-Wsign-conversion"
# pragma GCC diagnostic ignored "-Woverflow"
#endif
#ifdef _MSC_VER
# pragma warning(push, 3)
#endif
#include "absl/status/statusor.h"
#include "absl/types/span.h"
#ifdef __GNUC__
# pragma GCC diagnostic pop
#endif
#ifdef _MSC_VER
# pragma warning(pop)
#endif

#include "elisp/platform.h"
#include "elisp/process.h"
Expand Down
16 changes: 0 additions & 16 deletions elisp/launcher.cc
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -14,28 +14,12 @@

#include <cstdlib>

#ifdef __GNUC__
# pragma GCC diagnostic push
# pragma GCC diagnostic ignored "-Wpedantic"
# pragma GCC diagnostic ignored "-Wconversion"
# pragma GCC diagnostic ignored "-Wsign-conversion"
# pragma GCC diagnostic ignored "-Woverflow"
#endif
#ifdef _MSC_VER
# pragma warning(push, 3)
#endif
#include "absl/container/fixed_array.h"
#include "absl/log/log.h"
#include "absl/meta/type_traits.h"
#include "absl/status/status.h"
#include "absl/status/statusor.h"
#include "absl/types/span.h"
#ifdef __GNUC__
# pragma GCC diagnostic pop
#endif
#ifdef _MSC_VER
# pragma warning(pop)
#endif

#include "elisp/platform.h"

Expand Down
16 changes: 0 additions & 16 deletions elisp/process.cc
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -52,16 +52,6 @@
#include <utility>
#include <vector>

#ifdef __GNUC__
# pragma GCC diagnostic push
# pragma GCC diagnostic ignored "-Wpedantic"
# pragma GCC diagnostic ignored "-Wconversion"
# pragma GCC diagnostic ignored "-Wsign-conversion"
# pragma GCC diagnostic ignored "-Woverflow"
#endif
#ifdef _MSC_VER
# pragma warning(push, 3)
#endif
#include "absl/algorithm/container.h"
#include "absl/base/attributes.h"
#include "absl/base/nullability.h"
Expand All @@ -78,12 +68,6 @@
#include "absl/strings/str_join.h"
#include "absl/types/span.h"
#include "tools/cpp/runfiles/runfiles.h"
#ifdef __GNUC__
# pragma GCC diagnostic pop
#endif
#ifdef _MSC_VER
# pragma warning(pop)
#endif

#ifdef __APPLE__
# include <crt_externs.h> // for _NSGetEnviron
Expand Down
16 changes: 0 additions & 16 deletions elisp/process.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -22,24 +22,8 @@
#include <initializer_list>
#include <string_view> // IWYU pragma: keep

#ifdef __GNUC__
# pragma GCC diagnostic push
# pragma GCC diagnostic ignored "-Wpedantic"
# pragma GCC diagnostic ignored "-Wconversion"
# pragma GCC diagnostic ignored "-Wsign-conversion"
# pragma GCC diagnostic ignored "-Woverflow"
#endif
#ifdef _MSC_VER
# pragma warning(push, 3)
#endif
#include "absl/status/statusor.h"
#include "absl/types/span.h"
#ifdef __GNUC__
# pragma GCC diagnostic pop
#endif
#ifdef _MSC_VER
# pragma warning(pop)
#endif

#include "elisp/platform.h"

Expand Down
16 changes: 0 additions & 16 deletions elisp/proto/module.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -179,16 +179,6 @@ enum { kMaxIO = 0x7FFFF000 };
# error Emacs module header too old
#endif

#ifdef __GNUC__
# pragma GCC diagnostic push
# pragma GCC diagnostic ignored "-Wconversion"
# pragma GCC diagnostic ignored "-Wsign-conversion"
# pragma GCC diagnostic ignored "-Wpedantic"
#endif
#ifdef _MSC_VER
# pragma warning(push, 3)
# pragma warning(disable : 4090 4098 4244 4267 4334)
#endif
#include "absl/base/attributes.h"
#include "absl/base/config.h"
#include "google/protobuf/any.upb.h"
Expand All @@ -215,12 +205,6 @@ enum { kMaxIO = 0x7FFFF000 };
#include "upb/util/required_fields.h"
#include "upb/wire/decode.h"
#include "upb/wire/encode.h"
#ifdef __GNUC__
# pragma GCC diagnostic pop
#endif
#ifdef _MSC_VER
# pragma warning(pop)
#endif

/// Global variables

Expand Down
16 changes: 0 additions & 16 deletions elisp/test.cc
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -16,24 +16,8 @@

#include <initializer_list>

#ifdef __GNUC__
# pragma GCC diagnostic push
# pragma GCC diagnostic ignored "-Wpedantic"
# pragma GCC diagnostic ignored "-Wconversion"
# pragma GCC diagnostic ignored "-Wsign-conversion"
# pragma GCC diagnostic ignored "-Woverflow"
#endif
#ifdef _MSC_VER
# pragma warning(push, 3)
#endif
#include "absl/status/statusor.h"
#include "absl/types/span.h"
#ifdef __GNUC__
# pragma GCC diagnostic pop
#endif
#ifdef _MSC_VER
# pragma warning(pop)
#endif

#include "elisp/platform.h"
#include "elisp/process.h"
Expand Down
5 changes: 5 additions & 0 deletions examples/ext/.bazelrc
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -12,6 +12,11 @@
# See the License for the specific language governing permissions and
# limitations under the License.

# The external_include_paths feature has to be specified in .bazelrc because it
# needs to apply to all compile actions in all repositories.
# TODO: File bug against Bazel to make this work as repository-level feature.
build --features=external_include_paths --host_features=external_include_paths

import %workspace%/../../c-std.bazelrc

try-import %workspace%/../../github.bazelrc
9 changes: 9 additions & 0 deletions private/defs.bzl
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -450,6 +450,15 @@ COPTS = select({
"-pedantic",
"-pedantic-errors",
],
}) + select({
Label("//private:clang"): [
# This shouldn’t be needed, but the external_include_paths feature
# doesn’t work on macOS.
# TODO: File bug against Bazel.
"--system-header-prefix=absl/",
"--system-header-prefix=upb/",
],
Label("//conditions:default"): [],
})

CXXOPTS = select({
Expand Down
Loading