Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Image returns 404 #34

Open
samundra opened this issue Dec 31, 2018 · 1 comment
Open

Image returns 404 #34

samundra opened this issue Dec 31, 2018 · 1 comment

Comments

@samundra
Copy link
Member

There is reference to a image in page
https://github.com/phpearth/PHP.earth/blob/master/questions.md Currently, it returns 404.

The link to image is

https://camo.githubusercontent.com/57a334393333218faad318cc8c78ddc08528ab40/68747470733a2f2f6d656469612e67697068792e636f6d2f6d656469612f336f687334416130635665345832324b766d2f67697068792e676966
@Maikuolan
Copy link
Member

Seems to be something going on with the way GitHub is rendering image tags here which point canonically to Giphy URLs.

Viewing the rendered "source" of the page when actually viewing the page, we see this:

<img src="https://camo.githubusercontent.com/82753e49528717d94fd02d36a798a80ebbbdb9b4089322984e1fa8a75b009eda/68747470733a2f2f6d656469612e67697068792e636f6d2f6d656469612f336f687334416130635665345832324b766d2f67697068792e676966" alt="Research the problem" data-animated-image="" data-canonical-src="https://media.giphy.com/media/3ohs4Aa0cVe4X22Kvm/giphy.gif" style="max-width: 100%;">

But, when checking out the repo and accessing the actual file in question at its source, at that same line in the file, for that same tag, we instead see this:

<img src="https://media.giphy.com/media/3ohs4Aa0cVe4X22Kvm/giphy.gif" alt="Research the problem">

The Giphy URL seems to (somewhat) work correctly (albeit, I think it's meant to be animated, and at my end, it appears as a non-animated, still image), but GitHub's own URL for the image in question doesn't.

I was planning to push a commit to fix this just now, but not entirely sure at this point what would actually be needed to "fix" this.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants