[PHP 8.4] sockets constant list update #4154
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
devnexen
force-pushed
the
socket_upd_84
branch
from
8cc87f5
to
01132b1
Compare
|
for #3872 |
Girgias
requested changes
Nov 26, 2024
| <listitem> | ||
| <simpara> | ||
| Set the socket to a datagram congestion control protocol. | ||
| Available as of PHP 8.4.0 (NetBSD only) |
There was a problem hiding this comment.
Please add a full stop at the end of the "Available as of PHP 8.4.0." for all the constants
Suggested change
| Available as of PHP 8.4.0 (NetBSD only) | |
| Available as of PHP 8.4.0. (NetBSD only) |
Comment on lines
+2818
to
+2819
| Set the port range used for selecting a local port number. | ||
| Available as of PHP 8.4.0 (FreeBSD/NetBSD/OpenBSD only) |
There was a problem hiding this comment.
Tabs usage?
Suggested change
| Set the port range used for selecting a local port number. | |
| Available as of PHP 8.4.0 (FreeBSD/NetBSD/OpenBSD only) | |
| Set the port range used for selecting a local port number. | |
| Available as of PHP 8.4.0 (FreeBSD/NetBSD/OpenBSD only) |
Comment on lines
+2830
to
+2831
| Use the default range of port values. | ||
| Available as of PHP 8.4.0 (FreeBSD/NetBSD/OpenBSD only) |
There was a problem hiding this comment.
Ditto tabs
Suggested change
| Use the default range of port values. | |
| Available as of PHP 8.4.0 (FreeBSD/NetBSD/OpenBSD only) | |
| Use the default range of port values. | |
| Available as of PHP 8.4.0 (FreeBSD/NetBSD/OpenBSD only) |
Comment on lines
+2854
to
+2855
| Use a low range of port values. | ||
| Available as of PHP 8.4.0 (FreeBSD/NetBSD/OpenBSD only) |
There was a problem hiding this comment.
Suggested change
| Use a low range of port values. | |
| Available as of PHP 8.4.0 (FreeBSD/NetBSD/OpenBSD only) | |
| Use a low range of port values. | |
| Available as of PHP 8.4.0 (FreeBSD/NetBSD/OpenBSD only) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.