Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add PWA features to template #8

Open
macdonst opened this issue May 29, 2017 · 6 comments
Open

Add PWA features to template #8

macdonst opened this issue May 29, 2017 · 6 comments

Comments

@macdonst
Copy link
Member

Ran Lighthouse against an app created with this template and it scored:

screenshot 2017-05-29 15 13 59

This issue is to track the improvement of the template adding PWA functionality.

@macdonst
Copy link
Member Author

You can now see a live example of this template at: http://phonegap.com/phonegap-template-vue-f7-blank/#!//

@macdonst
Copy link
Member Author

Because of some url re-writing at phonegap.github.com the live example is now at:

https://macdonst.github.io/pwatest/#!//

@macdonst
Copy link
Member Author

Played around with PWA'ing the template and got it to this stage:

screenshot 2017-05-29 20 51 20

Something went wrong with Lighthouse which is why performance is 0 and we are stuck at 91 on PWA.

@macdonst
Copy link
Member Author

macdonst commented May 30, 2017

Things I learned:

  1. We need to handle icons better. It would be great if we automatically generated icon/splashscreen images.
  2. We should add a noscript tag to our main html file. DONE
  3. We should add a meta tag with the theme-color attribute and a theme-color in manifest.json. Ideally it should match the color used by F7.
  4. The index.html file should have a link to manifest.json.
  5. Should include a serviceWorker and the manifest should be automatically generated.

@hollyschinsky
Copy link
Contributor

@devgeeks
Copy link
Contributor

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

No branches or pull requests

3 participants