New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Not urlencoding url segment #188

Open

mokkabonna opened this issue Jun 26, 2017 · 0 comments

Contributor

mokkabonna commented Jun 26, 2017

I am doing an

octo.repos('mokkabonna', 'myrepo').compare('master', 'branch-with-æøå')

and get a 400 from github api. If I urlencode the parameter it works fine:

octo.repos('mokkabonna', 'myrepo').compare('master', encodeURIComponent('branch-with-æøå'))

I assumed this is something octokat should do by itself. Might not be the case, but wanted to report it anyway.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment